studio icon indicating copy to clipboard operation
studio copied to clipboard

Replace <Checkbox> with KDS Component, KCheckbox

Open marcellamaki opened this issue 4 years ago • 4 comments

Currently in Studio we are using the <Checkbox/> component, rather than the KDS KCheckbox. To standardize user experience and get the benefits of using our design system, we should use the <KCheckbox/> in place of <Checkbox/>

The user should not experience major changes, and all checkboxes should continue to work as they were before

Considerations

It is used 43 times, across 29 files, in Studio. Replacing the components should be fairly straightforward, as there are no additional layers on interconnection or dependencies found while preparing the issue.

The props for KCheckbox are available in the design system documentation, as well as additional information about events and methods.

note:

While making this update, an additional goal/benefit would be to ensure that when converting the component, that the usage of a checkbox at all follows our KDS guidance about when checkboxes are appropriate:

The checkbox is generally used to select one of two possible values in a form. It should not be used to make real-time changes; for this situation, use a KSwitch component instead.

If there are any instances where KSwitch would be better, it would be helpful to either make those changes or create a new issue.

marcellamaki avatar Apr 13 '21 21:04 marcellamaki

Hi @marcellamaki , Is this issue open to external contributors? If so, I can work on this.

Abhishek-Punhani avatar Feb 24 '25 18:02 Abhishek-Punhani

Hi @Abhishek-Punhani I will reference you to the contributing guidelines, where you can find out more about on what issues it's meaningful to ask for an assignment. I'd appreciate if you followed them.

I know you are motivated by GSOC and we do appreciate all the work you've done so far, however we can't assign you all issues you comment on as those are not ready for work. Regarding this potentially pre-GSOC period of time, I also wanted to mention that it's not about the number of resolved issues. Please use 'help wanted' as an opportunity to get to know our team and the codebase - that's all that is really needed :) Thank you.

MisRob avatar Feb 27 '25 05:02 MisRob

@MisRob , I apologize for inconvenience , I was just going through some old pending issues and didn’t mean to overstep. Thanks for your patience and guidance!

Abhishek-Punhani avatar Feb 27 '25 11:02 Abhishek-Punhani

No worries @Abhishek-Punhani, thank you for you understanding

MisRob avatar Feb 27 '25 11:02 MisRob