kolibri
kolibri copied to clipboard
learningequality
Check 0.16 onboarding strings
Follow up issue from https://github.com/learningequality/kolibri/pull/9534.
Observed behavior
In the 0.16 setup wizard we changed almost all the instances of the word facility into learning facility to give better context for localization, but there may be some that were not changed in #9534. This change is applicable only to the setup wizard pages where we have no screen space concerns, while in the actionable elements like buttons in the rest of the UI the string will remain just facility.
Figma designs
Import facility: Desktop | Mobile Loading Facility: Desktop | Mobile Mobile 2 Select super admin: Desktop | Mobile
Errors and logs
…
Expected behavior
All onboarding (setup wizard) pages use learning facility instead of just facility.
User-facing consequences
…
Steps to reproduce
…
Context
- Kolibri version: 0.16
Hi @camperjett - you are welcome to take a look at this - this would be on the develop branch, confirming that we have not missed any instances of this. Please search for all instances of facility in user facing strings in the setup wizard and ensure that we have updated to learning facility.
Hello @camperjett, are you working on this issue? else I'm interested to contribute for the same.
Hi @10kartik, thank you for your interest. As we haven't heard from @camperjett for some time, and we will need to have this ready before the next major release, if you're interested, you're welcome to tackle this issue. If you could let me know as soon as you start working, that'd be helpful so we know that it's in progress. Otherwise, we will assign this to one of the core team members in the next couple of weeks.
Yeah @MisRob, I'd like to give it a try! I'll try to explore more around and fix this issue. Thanks!
@10kartik We realized that this might be hard to test and preview due to some work in progress on develop and also because of design access. It's not that it would be impossible, though if you haven't started working on this yet, I'd recommend choosing another issue.