kolibri icon indicating copy to clipboard operation
kolibri copied to clipboard

Responsive behaviors on setup wizard language switcher list no longer work as originally designed

Open indirectlylit opened this issue 3 years ago • 6 comments

Observed behavior

The number of visible languages is changing based on screen size breakpoints even though the available space is not changing.

This may have been an unintentional consequence of some unrelated layout changing, e.g. making the max-width of the setup wizard smaller.

2021-04-12 12 19 26

Expected behavior

UI layout should be responsive to actual available screen real estate.

User-facing consequences

Layout and text wrapping behavior on the very first screen users see behaves poorly.

Steps to reproduce

resize setup wizard window

Context

0.14.7 rc2 0.16.0b10

indirectlylit avatar Apr 12 '21 19:04 indirectlylit

@radinamatic this one is still valid in 0.16.0b10

pcenov avatar Jan 05 '24 14:01 pcenov

@rtibbles Can I work on this issue?

FidalMathew avatar Feb 04 '24 04:02 FidalMathew

Hi @FidalMathew! Sure! I will assign this issue to you. Thank you!

AlexVelezLl avatar Feb 05 '24 20:02 AlexVelezLl

https://github.com/learningequality/kolibri/assets/84982038/8e7f8418-a30f-445d-8ef4-82fad6a2f08a

@AlexVelezLl I think the setup_wizard page doesn't exist now. The language option is present on the auth/#/signin page. Can you confirm this? Let me know if any changes are required. Thank you!

FidalMathew avatar Feb 06 '24 04:02 FidalMathew

@FidalMathew - the setup wizard still exists, however, you need to have a fresh KOLIBRI_HOME directory in order to see it, it is only used during initial setup.

You can see it again by running Kolibri with the KOLIBRI_HOME environment variable set to a new folder (if it doesn't exist, it will be created). When I do this, I tend to just use today's date as the folder name: KOLIBRI_HOME=~/.20240206 yarn run devserver-hot - this will run with a fresh folder, and should show you the setup wizard.

rtibbles avatar Feb 06 '24 17:02 rtibbles

Thanks, @rtibbles got it!

FidalMathew avatar Feb 08 '24 11:02 FidalMathew

Fixed in #11847.

AlexVelezLl avatar Feb 28 '24 20:02 AlexVelezLl