kolibri icon indicating copy to clipboard operation
kolibri copied to clipboard

put buttons in bottom bar on full-screen modals

Open indirectlylit opened this issue 5 years ago • 5 comments

Observed behavior

Modals such as 'create new user' have inline buttons, forcing you to scroll down to submit:

image

Expected behavior

some of our more recent full-screen modals have buttons in the bottom bar, which is more convenient and prominently displays call to action:

image

User-facing consequences

extra scrolling and less obvious calls to action

Context

0.13.0 beta 3

indirectlylit avatar Dec 05 '19 16:12 indirectlylit

should be addressed by work @khangmach is doing

indirectlylit avatar May 23 '20 10:05 indirectlylit

@khangmach - did you create a list of places where this change needs to happen by any chance?

nucleogenesis avatar Mar 11 '21 22:03 nucleogenesis

@nucleogenesis not yet

khangmach avatar Mar 11 '21 22:03 khangmach

  • Tomiwa: not easy to see potential edge cases before we start - so may make the work a bit harder.

  • Radina & Petar perhaps could audit during integration tests

Next steps? Target?

  • Marcella: Could be good to prioritize in 0.16 as it would improve mobile experience

-- will assign to Radina, QA team will identify places where this change can be made

Jacob: Perhaps this can be patch release-friendly work

Marcella: Could also start on 0.15 for finding places where this is the case.

nucleogenesis avatar Oct 18 '22 17:10 nucleogenesis

@radinamatic Here is a list with all the pages that would benefit for this change:

Create an account: http://127.0.0.1:8080/en/auth/#/create_account?step=1 Edit profile: http://127.0.0.1:8080/en/profile/#/edit Device > Permissions > Edit permissions: http://127.0.0.1:8080/en/device/#/permissions Device > Settings: http://127.0.0.1:8080/en/device/#/settings Facility > Users > New user: http://127.0.0.1:8080/en/facility/#/users/new Facility > Users > Edit details Facility > Settings: http://127.0.0.1:8080/en/facility/#/settings Facility > Data > Import users from spreadsheet: http://127.0.0.1:8080/en/facility/#/data/import

pcenov avatar Dec 19 '22 14:12 pcenov