kolibri icon indicating copy to clipboard operation
kolibri copied to clipboard

Localized strings can be too long for the Resource Download button

Open jonboiser opened this issue 5 years ago • 16 comments

Observed behavior

For example, in Yorùbá, the HTML5 version of the button message is too long and will push out the file size.

Screen Shot 2019-05-24 at 4 30 42 PM

Expected behavior

There is a way the entire message can be read from the button, even when the localized message is very long. We should use our text truncator on the title so the file size is always visible.

User-facing consequences

Errors and logs

Steps to reproduce

Context

Kolibri 0.12.4 at eeb25665e80b256c78934f74119efb9c279c0bcc

jonboiser avatar May 24 '19 23:05 jonboiser

It's possible that the text truncator css component could help with this.

rtibbles avatar Jan 03 '24 20:01 rtibbles

Hi, I'd like to work on this issue, can I get assigned?

deveshidwivedi avatar Feb 14 '24 01:02 deveshidwivedi

Yes - note that my comment about the text truncator is about using that on the title, so that the file size always gets displayed.

rtibbles avatar Feb 14 '24 14:02 rtibbles

Hi @deveshidwivedi, is this issue work in progress or should we unassign?

MisRob avatar Mar 15 '24 14:03 MisRob

Hi @MisRob, I will not be unable to complete the task due to other commitments. Thank you for asking!

deveshidwivedi avatar Mar 17 '24 17:03 deveshidwivedi

Thanks for the message @deveshidwivedi

MisRob avatar Mar 18 '24 07:03 MisRob

@MisRob I would like to be assigned to work on this issue please

kafukoM avatar Mar 18 '24 07:03 kafukoM

Hi @kafukoM - thanks for your interest. We will assign you. Please ask here on the issue if you have any questions.

marcellamaki avatar Mar 18 '24 14:03 marcellamaki

Hi @kafukoM, are you working on this or would it better to unassign?

MisRob avatar May 11 '24 08:05 MisRob

Hi @kafukoM, are you working on this or would it better to unassign?

It would be better to reassign. Apologies for the late communication

kafukoM avatar May 13 '24 17:05 kafukoM

Un-assigning for now. Thanks @kafukoM!

akolson avatar May 13 '24 17:05 akolson