kolibri
kolibri copied to clipboard
EPUB search results highlight multiple instances of the search token within a single result
Observed behavior
During search, it's possible that multiple results appear within the same context:
However then a separate link and context is shown for each result. This makes it look like there are 4 results instead of 2.
Expected behavior
Only have a single link and quoted context section on the right-hand bar. This will make clear that the two results are the only ones visible
User-facing consequences
Initially I thought there were 4 results instead of 2
Steps to reproduce
- Go to http://kolibri-beta.learningequality.org/learn/#/topics/c/3a721243e176458aae5563fd030c9858
- search for 'chord'
Context
develop
cc @christianmemije
This seems to be a constraint of mark.js
. I don't think we can disambiguate between chord (1)
and chord (2)
.
It might be an improvement to collapse results like these that are very close in location into a single search result. For me, clicking either result doesn't result in a page change.
@radinamatic this one is still extant in 0.15.1: