kolibri icon indicating copy to clipboard operation
kolibri copied to clipboard

Fixes occasional error during pre-commit hook runs where the kolibri package.json was empty

Open rtibbles opened this issue 1 month ago • 1 comments

Summary

Slightly rejig api spec tools to prevent errors during the core-api-js pre-commit hook. Previously the kolbiri package package.json was loaded in module scope, which caused weird interactions while running the build_kolibri_package script, which would rewrite the package.json file.

References

No issue - just observed in multiple pre-commit runs on Github Actions and locally.

Reviewer guidance

I confirmed this fixed a persistence and recurrent instance of this when running in https://github.com/learningequality/kolibri/pull/13981

The best way to check this works is to make a change within the kolibri NPM package and then try to commit it - then confirm that the hook runs without errors.

rtibbles avatar Dec 09 '25 01:12 rtibbles