kolibri icon indicating copy to clipboard operation
kolibri copied to clipboard

Updates "Section Settings" Side panel UI

Open AllanOXDi opened this issue 9 months ago • 4 comments

Summary

This PR updates the section title in the edit section UI

Closes #13107

After

Screenshot 2025-03-21 at 16 46 53

Before

Screenshot 2025-03-21 at 16 48 06

References

#13107

Reviewer guidance

  1. See https://www.figma.com/design/lVJt5ukOrxS9qay0rXy7GC/0.18-Coach-updates?node-id=107-20607&p=f&t=VBq8IMW8iRQB1p7u-0

  2. Navigate to Create quiz

  3. Click on the Options button

  4. Select the edit section

AllanOXDi avatar Mar 21 '25 13:03 AllanOXDi

Agreed, there shouldn't be a border beneath the title section, and there also shouldn't be a border on the bottom bar. I think the border under the title section is currently implemented in different side panels across the app and it'd be good to remove that at some point

jtamiace avatar Mar 25 '25 20:03 jtamiace

HI @jtamiace does this change looks good to you?

Screenshot 2025-04-01 at 22 07 29

AllanOXDi avatar Apr 01 '25 19:04 AllanOXDi

As a secondary thought - if you run into challenges with this (updating the CSS styles, the title/header patterns, etc.), this is really useful information for our side panel refactoring work! You can share that as part of our conversations

marcellamaki avatar May 07 '25 13:05 marcellamaki

The underline should be removed, it's part of the spec (see above). I think we have some further side panel cleanup here to do for consistency, but I don't think that's in scope for @AllanOXDi 's PR here. I will need to think then if we should merge this now for 0.18 patch 2 and have it not match, or if we should merge this into develop and do all of the cleanup in 0.19

marcellamaki avatar Jul 24 '25 15:07 marcellamaki