kolibri icon indicating copy to clipboard operation
kolibri copied to clipboard

Delete resource from everywhere when force_delete is selected

Open thesujai opened this issue 1 year ago • 1 comments

Summary

  1. Whenever force_delete is selected, the ContentNodes with same content_id is appended to the node_ids so the content can be deleted from everywhere
  2. Adds a validate method to DeleteChannelValidator so force_delete wont be ignored in the validation process

References

Fixes #12606

Reviewer guidance

Try and replicate this, if it doesn't replicate then we are good to go.


Testing checklist

  • [x] Contributor has fully tested the PR manually
  • [ ] If there are any front-end changes, before/after screenshots are included
  • [ ] Critical user journeys are covered by Gherkin stories
  • [ ] Critical and brittle code paths are covered by unit tests

PR process

  • [x] PR has the correct target branch and milestone
  • [ ] PR has 'needs review' or 'work-in-progress' label
  • [ ] If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • [ ] If this is an important user-facing change, PR or related issue has a 'changelog' label
  • [ ] If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

thesujai avatar Sep 25 '24 20:09 thesujai

Just did a quick retarget and rebase, as this is aimed at 0.17 planned patch 2. Will merge once the build completes.

rtibbles avatar Oct 23 '24 15:10 rtibbles