[DO NOT MERGE until #12418]Accessible channel card
Summary
…
References
…
Reviewer guidance
…
Testing checklist
- [ ] Contributor has fully tested the PR manually
- [ ] If there are any front-end changes, before/after screenshots are included
- [ ] Critical user journeys are covered by Gherkin stories
- [ ] Critical and brittle code paths are covered by unit tests
PR process
- [ ] PR has the correct target branch and milestone
- [ ] PR has 'needs review' or 'work-in-progress' label
- [ ] If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
- [ ] If this is an important user-facing change, PR or related issue has a 'changelog' label
- [ ] If this includes an internal dependency change, a link to the diff is provided
Reviewer checklist
- PR is fully functional
- PR has been tested for accessibility regressions
- External dependency files were updated if necessary (
yarnandpip) - Documentation is updated
- Contributor is in AUTHORS.md
Build Artifacts
| Asset type | Download link |
|---|---|
| PEX file | kolibri-0.18.0.dev0_git.20241015203316.pex |
| Windows Installer (EXE) | kolibri-0.18.0.dev0+git.20241015203316-windows-setup-unsigned.exe |
| Debian Package | kolibri_0.18.0.dev0+git.20241015203316-0ubuntu1_all.deb |
| Mac Installer (DMG) | kolibri-0.18.0.dev0+git.20241015203316.dmg |
| Android Package (APK) | kolibri-0.18.0.dev0+git.20241015203316-0.1.4-debug.apk |
| TAR file | kolibri-0.18.0.dev0+git.20241015203316.tar.gz |
| WHL file | kolibri-0.18.0.dev0+git.20241015203316-py2.py3-none-any.whl |
@AllanOXDi please let me know when this is ready for final review. I was just going through all card work so I left some notes here already for important changes. However, I think after that's done, there won't be much else here, perhaps some minor details. Nice work overall.
@MisRob would you mind giving this another look?
Hi @AllanOXDi, yes - would you please clean up temporary code? As I've already seen this before, I think I will only do a final pre-merge review when everything's ready. Thanks for preparing everything for easier testing :)
Done!
Hey @AllanOXDi! I just merged #12717 which had some KCard breaking changes. Could you please rebase the branch, and update the layout prop to orientation as this is one of the breaking changes introduced in the latest KDS version https://github.com/learningequality/kolibri-design-system/releases/tag/v5.0.0-rc7 :)
Two last things, @AllanOXDi, and then can be merged :)