kolibri icon indicating copy to clipboard operation
kolibri copied to clipboard

[DO NOT MERGE until #12418]Accessible channel card

Open AllanOXDi opened this issue 1 year ago • 2 comments

Summary

References

Reviewer guidance


Testing checklist

  • [ ] Contributor has fully tested the PR manually
  • [ ] If there are any front-end changes, before/after screenshots are included
  • [ ] Critical user journeys are covered by Gherkin stories
  • [ ] Critical and brittle code paths are covered by unit tests

PR process

  • [ ] PR has the correct target branch and milestone
  • [ ] PR has 'needs review' or 'work-in-progress' label
  • [ ] If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • [ ] If this is an important user-facing change, PR or related issue has a 'changelog' label
  • [ ] If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

AllanOXDi avatar Aug 27 '24 11:08 AllanOXDi

@AllanOXDi please let me know when this is ready for final review. I was just going through all card work so I left some notes here already for important changes. However, I think after that's done, there won't be much else here, perhaps some minor details. Nice work overall.

MisRob avatar Aug 28 '24 05:08 MisRob

@MisRob would you mind giving this another look?

AllanOXDi avatar Oct 01 '24 16:10 AllanOXDi

Hi @AllanOXDi, yes - would you please clean up temporary code? As I've already seen this before, I think I will only do a final pre-merge review when everything's ready. Thanks for preparing everything for easier testing :)

MisRob avatar Oct 07 '24 13:10 MisRob

Done!

AllanOXDi avatar Oct 14 '24 11:10 AllanOXDi

Hey @AllanOXDi! I just merged #12717 which had some KCard breaking changes. Could you please rebase the branch, and update the layout prop to orientation as this is one of the breaking changes introduced in the latest KDS version https://github.com/learningequality/kolibri-design-system/releases/tag/v5.0.0-rc7 :)

AlexVelezLl avatar Oct 14 '24 14:10 AlexVelezLl

Two last things, @AllanOXDi, and then can be merged :)

MisRob avatar Oct 15 '24 16:10 MisRob