kolibri icon indicating copy to clipboard operation
kolibri copied to clipboard

[DO NOT MERGE] Test KDS#744 - KCheckbox regression testing

Open nucleogenesis opened this issue 1 year ago • 3 comments

Summary

A PR for testing for regressions in Kolibri with significant changes to KCheckbox in KDS.

References

https://github.com/learningequality/kolibri-design-system/pull/744

Reviewer guidance

With particular concern for any Checkboxes in Kolibri which can be indeterminate (ie, [-]) - test that they function appropriately visually and functionally.

The areas I've quickly tested were:

  • Content Import (Device)
  • Resource selection (Coach -> Quiz management)

It's worth also testing any other uses of KCheckbox, such as:

  • Settings (Facility & Device)
  • Account creation
  • Any checkbox you see in your travels testing the other things above.

nucleogenesis avatar Aug 22 '24 15:08 nucleogenesis

Hi @nucleogenesis - the only regression issue which I was able to identify is at Device > Channels > Manage > Delete resource where the checkbox "Also delete any copies found in other locations and channels" cannot be selected:

https://github.com/user-attachments/assets/a31b3bb9-a02b-42ba-b74b-5c855904eb13

pcenov avatar Aug 23 '24 12:08 pcenov

I've added commits fixing bugs, all of which are basically "select all was not being indeterminate when it should".

I've tested every KCheckbox in Kolibri except ImportCSVPage/Init

All of the checkboxes except for those touched here worked as expected.

One place that was a bit of a challenge to get to was the "Don't show this again" in the "Quiz/Lesson Status" modals because they only show if you're on a device from which someone has imported/created a Learn-only Device.

nucleogenesis avatar Aug 27 '24 22:08 nucleogenesis

Hi @nucleogenesis could you check whether there's an issue with the build artefacts here? I am currently testing using kolibri_0.17.0a0.dev0+git.65.g5d08224e-0ubuntu1_all.deb and there are still several places where the 'Select all' checkbox doesn't change to indeterminate state at all. Such as:

  • Device > Channels > Options > Delete/Export channels
  • Facility > Class > Enroll learners/Assign coaches
  • Coach > Plan > Lesson > Manage resources
  • Coach > Plan > Groups > New group > Enroll learners

pcenov avatar Sep 04 '24 14:09 pcenov

@pcenov I restarted the builds and they look to have succeeded this time so they should be updated and ready for your review

nucleogenesis avatar Sep 06 '24 22:09 nucleogenesis

Thanks @nucleogenesis - I confirm that the above mentioned issues with the "Select all" checkbox are valid in the latest build and there's no indeterminate state here:

  • Device > Channels > Options > Delete/Export channels
  • Facility > Class > Enroll learners/Assign coaches
  • Coach > Plan > Lesson > Manage resources
  • Coach > Plan > Groups > New group > Enroll learners

pcenov avatar Sep 09 '24 08:09 pcenov

@pcenov the build assets weren't updated last time either, sorry for that. I've updated the PR overall and my tests pass so I think this should be ready to test again so long as those pass.

nucleogenesis avatar Sep 25 '24 22:09 nucleogenesis

Hi @nucleogenesis, the only remaining place where the 'Select all' still doesn't have an indeterminate state is at Coach > Plan > Lesson > Manage resources:

https://github.com/user-attachments/assets/38854d24-99c5-42db-9e5b-3d5d4a828dce

Let me know if this page is out of scope for this PR and I'll approve it!

pcenov avatar Sep 26 '24 11:09 pcenov

@pcenov good catch! I've fixed it

nucleogenesis avatar Sep 30 '24 20:09 nucleogenesis