learningequality
Remove hardcoded color used for the button hover state
🌱 Are you new to the codebase? Welcome! Please see the contributing guidelines.
Blocked by
- https://github.com/learningequality/kolibri-design-system/issues/726
Summary
After Kolibri Design System provides $darken_ utilities, let's use them to get rid of this hardcoded color https://github.com/learningequality/kolibri/blob/7ba25fd14e2df6127879111922316f1225a6d787/kolibri/plugins/coach/assets/src/views/common/QuizStatus.vue#L350 by applying the most appropriate $darken_ on the base red color color that the button has when it's not in hovered state.
Hi @lokesh-sagi125, welcome! Thanks for volunteering, we appreciate it.
Before this issue can be worked on, https://github.com/learningequality/kolibri-design-system/issues/726 needs to be resolved, and another contributor is already assigned to https://github.com/learningequality/kolibri-design-system/issues/726.
We welcome you on another issue! There are contributing opportunities in three repositories. See the contributing guidelines including links to issues suitable for contribution for each repository here:
- Kolibri Contributing Guidelines
- Kolibri Design System Contributing Guidelines
- Studio Contributing Guidelines
You can also see the list of unassigned "help wanted" or "good first issue" issues across all repositories.
Hi again @shivam-daksh , assigned, thanks a lot.
In Kolibri, you can use devserver-with-kds command to run Kolibri with your local KDS so you can access your work in https://github.com/learningequality/kolibri-design-system/pull/728.
Hi @shivam-daksh I wanted to check if you’re currently working on this issue. If not, I would love to contribute and take it up.
Hi @Aditya8840, An issue in #4634 was persisting. That's the reason it took a long delay. I'll work on this issue.
Thanks @shivam-daksh and welcome @Aditya8840.
@Aditya8840, there are other contributing opportunities in three repositories. See the contributing guidelines including links to issues suitable for contribution for each repository here:
- Kolibri Contributing Guidelines
- Kolibri Design System Contributing Guidelines
- Studio Contributing Guidelines
You can also see the list of unassigned "help wanted" or "good first issue" issues across all repositories.
Hi @MisRob , I'm getting error while installing dependencies using yarn install. I've attached the log file.
logs.txt
Hi @shivam-daksh! It appears, from the above, that you encountered some network connectivity issues(or the connection was not stable during the download) while downloading the dependencies. Could you delete the node_modules files and try to reinstall the dependencies again (yarn install)?
Below is a snippet from the attached logs.txt file attached
info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...
Hi @MisRob and @akolson , the issue is still persisting. I think it is not because of network error. Please check the logs in the end. I've tried with yarn install after deleting node_modules, still faced the same issue.
Hi @shivam-daksh, I'm sorry to hear it's troubling.
I wanted to recommend you Volta to manage your node version, however it seems you are already using it, am I right? The node version looks correct.
Did you follow https://kolibri-dev.readthedocs.io/en/develop/getting_started.html closely step by step before running yarn install? To understand whether there was an issue even before running yarn install.
If you haven't done so already, I'd recommend to delete the entire folder and try one more time. If it doesn't help, would you message us at [email protected] to receive Slack invitation and upload as many logs as possible from the whole setup process there?
Hi @MisRob,
I'm using Volta to manage my Node versions and followed the instructions from the Kolibri documentation exactly. When I tried this on GitHub Codespaces, the yarn install command completed without errors. However, after running yarn run devserver (or devserver-hot), the build was successful, but when I accessed the project through the forwarded port, I only saw Kolibri's loading screen with the logo. I waited for a while, but Kolibri never fully loaded.
I also tried deleting the entire folder and re-cloning the project on my local system, but I'm encountering the same issue with yarn install.
Any suggestions on how to resolve this?
@shivam-daksh Looking at logs, this seems to be something similar? https://github.com/nodejs/node-gyp/issues/2681. Would you try play around with some guidance offered there if so?