Fix list activity notifications

[AlexVelezLl]

Summary

…

References

…

Reviewer guidance

…

---

Testing checklist

• [ ] Contributor has fully tested the PR manually
• [ ] If there are any front-end changes, before/after screenshots are included
• [ ] Critical user journeys are covered by Gherkin stories
• [ ] Critical and brittle code paths are covered by unit tests

PR process

• [ ] PR has the correct target branch and milestone
• [ ] PR has 'needs review' or 'work-in-progress' label
• [ ] If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
• [ ] If this is an important user-facing change, PR or related issue has a 'changelog' label
• [ ] If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[github-actions[bot]]

Build Artifacts

Asset type	Download link
PEX file	kolibri-.pex
Windows Installer (EXE)	kolibri-0.17.0b3.dev0+git.43.g5bca68f7-windows-setup-unsigned.exe
Debian Package	kolibri_0.17.0b3.dev0+git.43.g5bca68f7-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.17.0b3.dev0+git.43.g5bca68f7.dmg
Android Package (APK)	kolibri-0.17.0b3.dev0+git.43.g5bca68f7-0.1.3-debug.apk
TAR file	kolibri-0.17.0b3.dev0+git.43.g5bca68f7.tar.gz
WHL file	kolibri-0.17.0b3.dev0+git.43.g5bca68f7-py2.py3-none-any.whl

[AlexVelezLl]

Thank you @rtibbles! I have updated the PR :)

[pcenov]

Hi @AlexVelezLl @radinamatic - the only issue I was able to identify while testing this is the following error in the console, with seemingly no user facing consequences but I'm going to mention it to be on the safe side:

TypeError: Cannot read properties of undefined (reading 'correct')

Logs: LogsAndDB.zip

Other than that everything else is working properly and I am seeing all of the notifications.

[rtibbles]

Looking at the component in question, this looks like an attemptLog was somehow undefined? https://github.com/learningequality/kolibri/blob/develop/kolibri/core/assets/src/views/AttemptLogItem.vue#L83

This is probably not caused by the changes here - @AlexVelezLl if you feel like chasing this down, please do, otherwise we can file a follow up issue.

[AlexVelezLl]

Im gonna give a try @rtibbles. If it becomes something too big we can file a follow up issue :)

[AlexVelezLl]

I did a little research, and this issue is happening in the ExamReport page of exercise resources because in the AttemptLogList we iterate through the section.questions, but for a practice resource we dont have attemptLogs for every question, since we dont necessarily have attempted every question, so that why this attemptLog is undefined here https://github.com/AlexVelezLl/kolibri/blob/17ab6f78c8808dbd7ae2f40b49b9b16a1582fc03/kolibri/core/assets/src/views/AttemptLogList.vue#L135.

Im not sure what the order should be in the exercises attemptLog and how should it be iterated. So it will be better to file a new issue to solve Exam Reports of exercise resources @rtibbles @pcenov @radinamatic.

[rtibbles]

Thanks, @AlexVelezLl - seems like this is likely a regression from the EQM work.