kolibri icon indicating copy to clipboard operation
kolibri copied to clipboard

Refactored HomePage route handler to fetch initClassInfo and getFacil…

Open shubh1007 opened this issue 1 year ago • 2 comments

Summary

This is the continuation of the refactoring process for the coach page, transitioning from a global route handler to local route handlers. #11219

References

List of all planRoutes:

Route name Handler/component to refactor Refactor done? How to test the page
PageNames.HOME_PAGE showHomePage yes Coach -> Class Home
HomeActivityPage.name showHomePage yes Coach -> Class Home -> activity

Reviewer guidance

Please follow the table for reviewing the refactored routes.

Testing checklist

  • [ ] Contributor has fully tested the PR manually
  • [ ] If there are any front-end changes, before/after screenshots are included
  • [ ] Critical user journeys are covered by Gherkin stories
  • [ ] Critical and brittle code paths are covered by unit tests

PR process

  • [ ] PR has the correct target branch and milestone
  • [ ] PR has 'needs review' or 'work-in-progress' label
  • [ ] If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • [ ] If this is an important user-facing change, PR or related issue has a 'changelog' label
  • [ ] If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • [ ] Automated test coverage is satisfactory
  • [ ] PR is fully functional
  • [ ] PR has been tested for accessibility regressions
  • [ ] Documentation is updated
  • [ ] Contributor is in AUTHORS.md

shubh1007 avatar Jun 25 '24 15:06 shubh1007

Hi @shubh1007, this is great! I can see you grasped the problem and the strategy for solving it, thanks a lot. This will really help us to unblock some important work. Leaving just a few details, but overall looks really good.

Do you wish to continue with some other routes from this file? If so, would you push them to this PR as well or would you rather work in a new one?

Note that I'm mostly offline until July 8 - just chiming in on this issue to confirm that you can continue if you'd like, and on some days I will be available to answer questions.

MisRob avatar Jun 25 '24 18:06 MisRob

Thanks for following up @shubh1007. I will finish review when I'm back online next week. Meanwhile, I feel confident that we're on the same page about this task so feel free to continue working on other routes if you'd like (or please message us if you don't want to work on more so we know we should re-assign)

MisRob avatar Jul 04 '24 17:07 MisRob