learningequality
Move login/logout logic into the useUser composable and update references
Prerequisites
- [x] https://github.com/learningequality/kolibri/issues/12203
The login, logout, and session actions should be migrated into the useUser composable.
As this will have been done after the migration of all references to the getters and state to the useUser composable, the state should be removed from Vuex state and made into module level state in the useUser composable. The getters should be transferred to the useUser composable as computed refs based on the module level state.
Any references to the CORE_SET_SESSION mutation should also be updated: https://github.com/learningequality/kolibri/blob/develop/kolibri/core/assets/src/state/modules/session.js#L89
Yes, certainly! Please feel free to ask any questions about this, and also look at previous related PRs for guidance!
hi @rtibbles , i opened a pr for this issue. i moved the login/logout logic along with session logic in useUser composable but when i tried to update the CORE_SET_SESSION, some tests failed. I am unable to figure out why.
Hi @iamshobhraj, I wanted to mention that Learning Equality will be closed from December 23 to January 5.
Hi @iamshobhraj are you still working on this issue if no then @rtibbles can assign it to me, if you are still working then all the best :)
There is some very strong work in progress here, that I am hopeful @iamshobhraj will come back to. If not, we will finish up this task.
Hi @rtibbles, I’ve decided to close the PR #12915 for now as I need more time to investigate and resolve the issue I was facing. In the meantime, please feel free to unassign me and reassign the issue to someone else if there’s interest. I’ll revisit this later and open a new PR if I’m able to fix it. Thanks for your support!