kolibri icon indicating copy to clipboard operation
kolibri copied to clipboard

Migrate all existing references to session getters and state to the useUser composable

Open rtibbles opened this issue 1 year ago • 2 comments

The useUser composable now encapsulates all the vuex getters and state for the session, we should migrate all references to these to instead import the useUser composable and read from there.

See the composable for the full list of getters and state that will need to be remapped: https://github.com/learningequality/kolibri/blob/develop/kolibri/core/assets/src/composables/useUser.js#L36

Note, this will not involve removing the session vuex module.

rtibbles avatar May 23 '24 20:05 rtibbles

Hi @rtibbles, can I try this issue?

nathanaelg16 avatar May 31 '24 14:05 nathanaelg16

Hi @nathanaelg16 - yes, please do!

When you make a pull request, I'd suggest making a commit 'per plugin' (learn, coach, etc. and one for the core references).

rtibbles avatar May 31 '24 15:05 rtibbles

Fixed in #12438 and #12611

rtibbles avatar Aug 28 '24 21:08 rtibbles