kolibri icon indicating copy to clipboard operation
kolibri copied to clipboard

Update eslint rules to use rules from eslint/vue where possible

Open rtibbles opened this issue 1 year ago • 7 comments

Observed behavior

@MisRob created multiple custom eslint rules for Vue components, which she also contributed upstream to eslint/vue. Many of these rules are now in the main eslint/vue package.

Expected behavior

We should use these rules from upstream (e.g. https://eslint.vuejs.org/rules/no-unused-properties.html#vue-no-unused-properties) where possible, and remove the code and tests for unused rules in this repository.

rtibbles avatar May 23 '24 15:05 rtibbles

May I work on this issue?

shubh1007 avatar Jun 16 '24 05:06 shubh1007

Hi @shubh1007 - that would be great! Before work can begin fully on this, this PR https://github.com/learningequality/kolibri/pull/9698 must be merged, but we are hoping to do that this coming week.

In the meantime, looking at the existing custom rules we have for vue components, which you can find in here: https://github.com/learningequality/kolibri/tree/develop/packages/eslint-plugin-kolibri/lib/rules and then seeing which ones will be redundant once we upgrade our vue eslint plugin version (see here for the complete list: https://eslint.vuejs.org/rules/) would be a great start!

I'll assign you, and if you can make a note of which rules you think you'll need to switch over in this issue, that would be super!

rtibbles avatar Jun 17 '24 02:06 rtibbles

Since the PR #9698 has been merged, I want to work upon this issue. Please describe the problem briefly so that I can understand the problem properly and resolve the issue. Thank you.

shubh1007 avatar Jul 02 '24 18:07 shubh1007

We have some rules in our custom rules https://github.com/learningequality/kolibri/tree/develop/packages/eslint-plugin-kolibri/lib/rules that have equivalents in https://eslint.vuejs.org/rules/

Find the ones that we can remove from our custom rules and use the eslint/vuejs rules instead.

rtibbles avatar Jul 02 '24 18:07 rtibbles

Hi @shubh1007, are you working on planning to work on this, or would it be better to unassign?

MisRob avatar Sep 03 '24 09:09 MisRob

You can unassign the task.

shubh1007 avatar Sep 03 '24 09:09 shubh1007

Alright, thanks for letting us know @shubh1007. Best wishes

MisRob avatar Sep 03 '24 09:09 MisRob