kolibri icon indicating copy to clipboard operation
kolibri copied to clipboard

Fixes accessibility issue when reading epubs

Open nathanaelg16 opened this issue 9 months ago • 6 comments

Summary

These changes fix the issue for those using tabs to navigate through books using the epub viewer library. Previously, one could never reach the Right Navigation button due to the tabindex terminating with the epub viewer. This change sets the first tab item to be the epubviewer, then all other tab-accessible items will follow the DOM order.

BEFORE

before

AFTER

after

References

#10371

Reviewer guidance

  1. Open an epub book to read
  2. Press tab repeatedly until it reaches the Right navigation button
  3. Trigger the Right navigation button (press tab or enter)
  4. Press tab repeatedly again until it reaches the right navigation button

Testing checklist

  • [X] Contributor has fully tested the PR manually
  • [X] If there are any front-end changes, before/after screenshots are included
  • [ ] Critical user journeys are covered by Gherkin stories
  • [ ] Critical and brittle code paths are covered by unit tests

PR process

  • [ ] PR has the correct target branch and milestone
  • [ ] PR has 'needs review' or 'work-in-progress' label
  • [ ] If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • [ ] If this is an important user-facing change, PR or related issue has a 'changelog' label
  • [ ] If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

nathanaelg16 avatar May 17 '24 16:05 nathanaelg16