kolibri
kolibri copied to clipboard
Update facility settings link display for Learn Only Device users
Summary
Previously admin users on a learn-only device could see "You can also configure Facility settings” link in Device settings, but users on a LOD cannot access the facility settings page. This pull request modifies the Device Settings page to display the link if the user is not on a Learn Only Device.
- Updates vuex
mapGetters
withisLearnerOnlyImport
on theDeviceSettingsPage
and modifies the conditional to display theKExternalLink
that leads toFacilityConfigPage
.
View of a super admin on a full device:
Updated view for admins on a learn only device:
References
Closes #11877
Reviewer guidance
- Follow the group learning setup and select Learn-Only device -> import or create a user account with an existing facility -> go to the Device settings page -> Verify that the message
The changes you make here will affect this device only.
is displayed. - Follow the On My Own setup -> go to Device settings page -> Verify that the message and link
The changes you make here will affect this device only. You can also configure device settings
are displayed.
Testing checklist
- [x] Contributor has fully tested the PR manually
- [x] If there are any front-end changes, before/after screenshots are included
PR process
- [ ] PR has the correct target branch and milestone
- [ ] PR has 'needs review' or 'work-in-progress' label
- [ ] If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
- [ ] If this is an important user-facing change, PR or related issue has a 'changelog' label
- [ ] If this includes an internal dependency change, a link to the diff is provided
Reviewer checklist
- Automated test coverage is satisfactory
- PR is fully functional
- PR has been tested for accessibility regressions
- External dependency files were updated if necessary (
yarn
andpip
) - Documentation is updated
- Contributor is in AUTHORS.md
Build Artifacts
Asset type | Download link |
---|---|
PEX file | kolibri-0.16.2b1.dev0_git.6.gfa6b8fc0.pex |
Windows Installer (EXE) | kolibri-0.16.2b1.dev0+git.6.gfa6b8fc0-windows-setup-unsigned.exe |
Debian Package | kolibri_0.16.2b1.dev0+git.6.gfa6b8fc0-0ubuntu1_all.deb |
Mac Installer (DMG) | kolibri-0.16.2b1.dev0+git.6.gfa6b8fc0-0.4.1.dmg |
Android Package (APK) | kolibri-0.16.2b1.dev0+git.6.gfa6b8fc0-0.1.2-debug.apk |
TAR file | kolibri-0.16.2b1.dev0+git.6.gfa6b8fc0.tar.gz |
WHL file | kolibri-0.16.2b1.dev0+git.6.gfa6b8fc0-py2.py3-none-any.whl |
@radinamatic can you confirm the fix manually here, and then we can merge?
Oh one thought here - as this doesn't involve any string updates, I think we could instead target this issue to the next 0.16 patch?
Thanks @LianaHarris360 - I confirm that this is implemented as specified above, no issues observed while manually testing.