kolibri icon indicating copy to clipboard operation
kolibri copied to clipboard

Don't let users that are used for os user have their passwords set via the not specified password flow.

Open rtibbles opened this issue 1 year ago • 2 comments

Summary

  • Adds checks in the session creation endpoint and nonspecifiedpassword setting endpoint to exclude users for which there is an OSUser model
  • Adds tests for the above

References

Fixes #12112

Reviewer guidance

This is probably best tested in the context of the Flatpak app @dylanmccall might be best placed to test this.


Testing checklist

  • [ ] Contributor has fully tested the PR manually
  • [ ] If there are any front-end changes, before/after screenshots are included
  • [ ] Critical user journeys are covered by Gherkin stories
  • [ ] Critical and brittle code paths are covered by unit tests

PR process

  • [ ] PR has the correct target branch and milestone
  • [ ] PR has 'needs review' or 'work-in-progress' label
  • [ ] If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • [ ] If this is an important user-facing change, PR or related issue has a 'changelog' label
  • [ ] If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

rtibbles avatar Apr 30 '24 23:04 rtibbles

In learningequality/kolibri-installer-gnome#99, I changed the flatpak manifest to include this patch, and it appears to solve the problem I reported. There's one other issue over there which is probably because it isn't going through the initialize API. Reading the code, I see the app needs to use that for FacilityUser.objects.get_or_create_os_user() to run given the current auth token :) So I'll need to fix that and keep poking at it just to be sure, but this is looking good to me.

dylanmccall avatar May 02 '24 00:05 dylanmccall