kolibri icon indicating copy to clipboard operation
kolibri copied to clipboard

Update now value in SyncStatusDisplay

Open AlexVelezLl opened this issue 9 months ago • 1 comments

Summary

Update now value in SyncStatusDisplay component.

https://github.com/learningequality/kolibri/assets/51239030/24946819-30e2-4209-bf46-cb0431036cbf

References

Closes #11880.

Reviewer guidance

  1. Set up two Kolibris - one as a Learn Only Device (LOD) and one as a full facility. The LOD should be set up to sync back the main facility
  2. Assign some resources to the Learner
  3. Observe the accuracy of sync status and the calculation of relative time
  4. Repeat if necessary

Testing checklist

  • [ ] Contributor has fully tested the PR manually
  • [ ] If there are any front-end changes, before/after screenshots are included
  • [ ] Critical user journeys are covered by Gherkin stories
  • [ ] Critical and brittle code paths are covered by unit tests

PR process

  • [x] PR has the correct target branch and milestone
  • [x] PR has 'needs review' or 'work-in-progress' label
  • [x] If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • [ ] If this is an important user-facing change, PR or related issue has a 'changelog' label
  • [ ] If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

AlexVelezLl avatar Apr 26 '24 16:04 AlexVelezLl

Hi @AlexVelezLl - I confirm that the syncing status is working correctly. Good to go!

pcenov avatar May 07 '24 13:05 pcenov

Thanks! @pcenov @radinamatic @rtibbles :tada:

AlexVelezLl avatar May 07 '24 13:05 AlexVelezLl