kolibri icon indicating copy to clipboard operation
kolibri copied to clipboard

tests: add tests for some components

Open EshaanAgg opened this issue 10 months ago • 1 comments

Summary

Introduced a test suite for the following components:

  • UserTypeDisplay.vue
  • FocusTrap.vue
  • TimeDuration.vue

References

Reviewer guidance


Testing checklist

  • [ ] Contributor has fully tested the PR manually
  • [ ] If there are any front-end changes, before/after screenshots are included
  • [ ] Critical user journeys are covered by Gherkin stories
  • [ ] Critical and brittle code paths are covered by unit tests

PR process

  • [ ] PR has the correct target branch and milestone
  • [ ] PR has 'needs review' or 'work-in-progress' label
  • [ ] If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • [ ] If this is an important user-facing change, PR or related issue has a 'changelog' label
  • [ ] If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

EshaanAgg avatar Apr 24 '24 07:04 EshaanAgg

Got it @rtibbles! Thanks for the review. I have updated to remove the reset test.

EshaanAgg avatar May 03 '24 18:05 EshaanAgg

Thank you @EshaanAgg - you responded so fast I was genuinely surprised!

rtibbles avatar May 03 '24 19:05 rtibbles

😂 I have an exam tomorrow, and the last paper syndrome has got me active on everything other than preparing for the same :) Thanks for the help on the PR!

EshaanAgg avatar May 03 '24 19:05 EshaanAgg

Many things have been achieved by students trying to avoid what they are meant to be working on!

rtibbles avatar May 03 '24 19:05 rtibbles