kolibri
kolibri copied to clipboard
tests: add tests for some components
Summary
Introduced a test suite for the following components:
-
UserTypeDisplay.vue
-
FocusTrap.vue
-
TimeDuration.vue
References
Reviewer guidance
…
Testing checklist
- [ ] Contributor has fully tested the PR manually
- [ ] If there are any front-end changes, before/after screenshots are included
- [ ] Critical user journeys are covered by Gherkin stories
- [ ] Critical and brittle code paths are covered by unit tests
PR process
- [ ] PR has the correct target branch and milestone
- [ ] PR has 'needs review' or 'work-in-progress' label
- [ ] If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
- [ ] If this is an important user-facing change, PR or related issue has a 'changelog' label
- [ ] If this includes an internal dependency change, a link to the diff is provided
Reviewer checklist
- Automated test coverage is satisfactory
- PR is fully functional
- PR has been tested for accessibility regressions
- External dependency files were updated if necessary (
yarn
andpip
) - Documentation is updated
- Contributor is in AUTHORS.md
Build Artifacts
Asset type | Download link |
---|---|
PEX file | kolibri-.pex |
Windows Installer (EXE) | kolibri-0.16.1.dev0+git.20240503184821-unsigned.exe |
Debian Package | kolibri_0.16.1.dev0+git.20240503184821-0ubuntu1_all.deb |
Mac Installer (DMG) | kolibri-0.16.1.dev0+git.20240503184821-0.4.2.dmg |
Android Package (APK) | kolibri-0.16.1.dev0+git.20240503184821-0.1.0-debug.apk |
TAR file | kolibri-0.16.1.dev0+git.20240503184821.tar.gz |
WHL file | kolibri-0.16.1.dev0+git.20240503184821-py2.py3-none-any.whl |
Got it @rtibbles! Thanks for the review. I have updated to remove the reset
test.
Thank you @EshaanAgg - you responded so fast I was genuinely surprised!
😂 I have an exam tomorrow, and the last paper syndrome has got me active on everything other than preparing for the same :) Thanks for the help on the PR!
Many things have been achieved by students trying to avoid what they are meant to be working on!