kolibri icon indicating copy to clipboard operation
kolibri copied to clipboard

Next attempt at fixing GCS upload

Open rtibbles opened this issue 1 year ago • 1 comments

Summary

  • My previous attempt to fix this was misguided - I assumed the issue was caused by the way the download artifact action was handling artifacts, but that was not the case.
  • Separate out BCK and other artifact upload.
  • Upload artifacts to LE downloads for all releases including prereleases, so we can test this sooner, and also get ready to create redirect links for prereleases.
  • Attempt to fix artifact upload by reverting previous change and changing destination argument for the google cloud upload seems promising due to this similar report https://github.com/google-github-actions/upload-cloud-storage/issues/353

References

Fixes #11908

Reviewer guidance

Clearly I was wrong last time - a quick read through and then we test this on prereleases is probably best!


Testing checklist

  • [ ] Contributor has fully tested the PR manually
  • [ ] If there are any front-end changes, before/after screenshots are included
  • [ ] Critical user journeys are covered by Gherkin stories
  • [ ] Critical and brittle code paths are covered by unit tests

PR process

  • [ ] PR has the correct target branch and milestone
  • [ ] PR has 'needs review' or 'work-in-progress' label
  • [ ] If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • [ ] If this is an important user-facing change, PR or related issue has a 'changelog' label
  • [ ] If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

rtibbles avatar Apr 09 '24 23:04 rtibbles