kolibri icon indicating copy to clipboard operation
kolibri copied to clipboard

Fix release workflow automatic upload GCS to not upload to folders

Open marcellamaki opened this issue 1 year ago • 3 comments

Observed behavior

In our new release automatic workflow, when the assets are uploaded to the GCS bucket, there is currently an extra folder level, with the name of the asset.

For example: ── 0.16.0/kolibri-0.16.0-0.4.0.dmg/kolibri-0.16.0-0.4.0.dmg

The correct structure should be 0.16.0/kolibri-0.16.0-0.4.0.dmg

Noting that even with the folder change, the Pi Image will need to be renamed to: e.g. kolibri-pi-image-0.16.0.zip

and the windows installer will need to be renamed to: e.g. kolibri-v0.16.0-windows-setup.exe

marcellamaki avatar Feb 20 '24 21:02 marcellamaki

Hi: Can I help with this one? 😄

Found this in the logs: Uploading ~/work/kolibri/kolibri/dist/kolibri-0.16.0-0.4.0.dmg to gs://***/downloads/kolibri/v0.16.0/kolibri-0.16.0-0.4.0.dmg/kolibri-0.16.0-0.4.0.dmg.

I think we can fix by changing here https://github.com/learningequality/kolibri/blob/develop/.github/workflows/release_kolibri.yml#L188.

emdneto avatar Feb 21 '24 12:02 emdneto

Hi @emdneto - thanks for your interest in contributing! This issue is already assigned to a member of our team, but you are welcome to look for another unassigned issue, particular one labeled "help wanted" to find another way to contribute.

marcellamaki avatar Feb 21 '24 12:02 marcellamaki

This is assumed to have been fixed by #12050.

If it is not fixed, we can reopen.

rtibbles avatar Apr 04 '24 20:04 rtibbles

Hopefully fixed in #12069

rtibbles avatar May 06 '24 22:05 rtibbles