kolibri icon indicating copy to clipboard operation
kolibri copied to clipboard

Insufficient storage banner - The 'Go to my downloads' button is not working / no space between the buttons

Open pcenov opened this issue 1 year ago • 3 comments

Observed behavior

While regression testing https://github.com/learningequality/kolibri/pull/11809 I noticed that the 'Go to my downloads' button is not working and there is no space between the 'Go to my downloads' and 'Mange channels' buttons. The 'Go to my downloads' is also not working if the LOD user is with no super admin permissions.

https://github.com/learningequality/kolibri/assets/79847249/d63dee0c-2cff-46ff-9ab5-d3831d82bf45

Expected behavior

Clicking on 'Go to my downloads' should bring the user to 'My downloads'. All the buttons should be displayed with enough space between them and displayed nicely in mobile view.

Steps to reproduce the issue

  1. Install the latest Beta 13 Android app.
  2. Setup a learn-only device by importing at least 2 learners.
  3. Sign in as the super admin learner, go to Device > Settings and enable both 'Allow learners to download resources' and 'Set storage limit for auto-download...'. Select 0 as the value.
  4. Go to the Library page and download a resource from a device in the 'Other libraries' section..
  5. Observe the insufficient storage banner and click the 'Go to my downloads' button.

Usage Details

Beta 13 Ubuntu 22 - Chrome Samsung Note 10 Lite, Android 13

pcenov avatar Feb 13 '24 13:02 pcenov

@radinamatic

pcenov avatar Feb 13 '24 13:02 pcenov

Can i work on this

iskipu avatar Feb 17 '24 07:02 iskipu

Hi @iskipu, yes, I will assign you. Thanks!

MisRob avatar Feb 19 '24 12:02 MisRob

@iskipu The last commit if a month old by you. Can you acknowledge if this being worked on. Further @MisRob can you confirm if this issue still persists.

himanshuc3 avatar Mar 20 '24 18:03 himanshuc3

Hi @himanshuc3,

I fixed the issue in the latter commits of https://github.com/learningequality/kolibri/pull/11809

Refer:https://github.com/learningequality/kolibri/pull/11809#issuecomment-1979114826

@MisRob i think this issue can be closed now. Looks like i haven't refered the issue in my latter commits so it caused the confusion sorry 😅.

iskipu avatar Mar 20 '24 18:03 iskipu

Thanks @iskipu :)

MisRob avatar Mar 21 '24 10:03 MisRob