More potential coach home loading states issues
Observed behavior
- Upon restarting the server VM, I see only one item in the Class activity panel, even though i know there have been many more. If I go to to
View allto see all notifications and come back to coach home, I see a few more, and if I go back to all notifications and click theShow moreat the bottom and then come back to coach home, I finally see the Class activity panel full.
https://github.com/learningequality/kolibri/assets/1457929/5472ff07-290e-4e97-bf52-3ac24ad547ae
- When more than 1 learner need help with an exercise in a lesson (or they completed an assignment), the notification always says
LearnerA and 1 other need help, but the status in the Lesson and Quizzes panel says otherwise. In fact, I wouldn't have even noticed that inconsistency, hadn't I also translated those strings back in a day and knowing that the string actually has a placeholder and should state how many others have completed the resource or need help.
Errors and logs
Windows 7 home folder (import Kolibri QA channel as it's not included in the ZIP)
Expected behavior
The notification in the Class activity panel should be consistent with the statuses in Lessons and Quizzes panel.
User-facing consequences
Inconsistent information provided to coaches about the class progress on assignments.
Steps to reproduce
You may need a DB with more class interactions to successfully debug, use the one provided above (creds for the superadmin are admin/pass).
Context
- Kolibri version: 0.16b13
- Operating system: Windows 7
HI @radinamatic i cannot access the link provided can you provide the access ?
@iskipu Thank you for being willing to contribute with this issue, but since it's marked to be fixed for our upcoming release, someone from our dev team is going to take it on.
After discussing with @rtibbles, we confirmed that this is actually the intended behavior, albeit (clearly) confusing.
- The "class activity" panel is the "most recent" notifications. On first page load, we only show recent events
- The left hand side panel (in 2) shows the summary from all time (an aggregate)
- The reason for the discrepancy is that perhaps [student and one other] had an update and need help (or completed) more recently than their classmates. So, two students "recently" need help, but on this lesson in total of all time, more have needed help
- When you do 'load more' on the all notifications page, and it loads more notifications, and then, by fetching more updates, the home page now has even more that are able to be displayed, beyond the initial fetch.
It will take some decisions to decide if the design here needs to be revised, because it can be confusing (as you have pointed out Radina). If the two columns were exactly aligned - what would be the design purpose of having this information in two places? It would perhaps get rid of the value of the "notifications" aspect of the feed, that reflects more recent activity. However, it does also seem that the fact that these are really "recent activity notifications" is unclear to the coach user, and some adjustments to the UI, whether through the text or design, may be useful. We might also want to change the expected behavior.