kolibri icon indicating copy to clipboard operation
kolibri copied to clipboard

Create equivalent of getters for all accessed session state and all getters in useUser composable

Open rtibbles opened this issue 1 year ago • 4 comments

We currently have multiple getters and even some state in the session.js Vuex module that is accessed throughout Kolibri.

We have started migrating these references to instead use the useUser core composable, but the composable still does not expose all the needed getters and state that are referenced across Kolibri.

To remedy this, all the getters that are defined in the session.js module should be exposed through the useUser composable in a similar way to those that have already been wrapped.

In addition, all state in the session module should be exposed for consumption via the composable as well.

rtibbles avatar Jan 12 '24 17:01 rtibbles

Hey @rtibbles, I can work on this issue, please assign me this issue

dhruvpal05 avatar Jan 16 '24 16:01 dhruvpal05

Sure thing!

rtibbles avatar Jan 16 '24 16:01 rtibbles

Hey @rtibbles, just created a PR for this #11738 , do review

dhruvpal05 avatar Jan 17 '24 13:01 dhruvpal05

I have reviewed, @dhruvpal05 - thanks for your efforts, but you seem to have misunderstood the issue. Please feel free to ask further clarifying questions on my review.

rtibbles avatar Jan 17 '24 15:01 rtibbles

I would like to work on this issue @rtibbles

Wck-iipi avatar Mar 27 '24 12:03 Wck-iipi

Hi @Wck-iipi, I assigned you to another issue recently, please finish the fix for that, and then we can revisit this.

rtibbles avatar Mar 27 '24 14:03 rtibbles

Ah, apologies, I see you've submitted a PR for that issue already! I'll assign you here.

rtibbles avatar Mar 27 '24 14:03 rtibbles