kolibri-design-system icon indicating copy to clipboard operation
kolibri-design-system copied to clipboard

KCardGrid: Set the default grid gap to 24px

Open MisRob opened this issue 8 months ago • 5 comments

Current behavior

By default, KCardGrid has 30px wide row and column gaps:

https://github.com/learningequality/kolibri-design-system/blob/6de7d6fa74dec1758dd07cf9e4908d5df04fb3e4/lib/cards/gridBaseLayouts.js#L8-L9

Expected behavior

As agreed with @jtamiace here, the default value for row and column gaps should be updated to 24px.

Guidance

Acceptance criteria

  • [ ] All usages of KCardGrid in Kolibri and Studio are reviewed. If 24px is set from there to override the previously default 30px (such as here), Kolibri and Studio pull requests should be open to remove such overrides since they won't be needed anymore.
  • [ ] All pull requests have before / after screenshots

MisRob avatar Apr 17 '25 14:04 MisRob

Hey @MisRob , can you assign this issue to me?

shruti862 avatar Apr 18 '25 07:04 shruti862

Thanks @shruti862! I will assign this to you!

AlexVelezLl avatar Apr 18 '25 14:04 AlexVelezLl

Hey @MisRob, Just wanted to confirm that for resolving this issue I need to do the following :

  1. Open a PR in this repo to modify the default grid gap of KCardGrid to 24px.
  2. Open a PR in Studio to remove the overrides that set the grid gap to 24px.
  3. Open a PR in Kolibri to do the same.

shruti862 avatar Apr 18 '25 19:04 shruti862

Hey @MisRob , @AlexVelezLl , I have raised PR please have a look whenever you have a moment and let me know if any changes needed :) A short note that I didn't found any usages of KCardGrid in studio so I raised PR for kds and kolibri only.

shruti862 avatar Apr 19 '25 08:04 shruti862

Yes @shruti862, this all makes sense to me and your pull requests look good overall. Thank you!

MisRob avatar Apr 22 '25 03:04 MisRob

Closed by https://github.com/learningequality/kolibri-design-system/pull/999

MisRob avatar May 22 '25 04:05 MisRob