kolibri-design-system icon indicating copy to clipboard operation
kolibri-design-system copied to clipboard

KTable docs small improvements

Open MisRob opened this issue 8 months ago • 1 comments

Description

  • Adds "Caption" usage section with brief guidance
    • Updates examples to reflect the guidance
  • Rephrases some props usage for more clarity and conciseness, and removes duplicate information
  • Removes unnecessary code comments

Issue addressed

Just noticed few places to improve as I was creating trivia.

Changelog

  • Description: Smaller improvements of KTable documentation page
  • Products impact: none
  • Addresses: -
  • Components: -
  • Breaking: -
  • Impacts a11y: -
  • Guidance: -

Steps to test

Have a look at the preview build.

MisRob avatar Apr 07 '25 10:04 MisRob

Thank you, @BabyElias.

Just a doubt, the fact that we are encouraging users to put translated strings as captions for the table - is there any way that this can be shown or referenced in the docs here?

Ah yes good point. The thing is that KDS itself never handles translations, so I am not sure how to best communicate it in more explicit manner. Do you have any ideas?

MisRob avatar Apr 15 '25 19:04 MisRob

@BabyElias Thank you for review, addressed. If all looks well, can you approve?

MisRob avatar Jun 09 '25 12:06 MisRob

Percy Visual Test Results

Percy Dashboard: View Detailed Report

Environment:

  • Node.js Version: 18.x
  • OS: Ubuntu-latest

Instructions for Reviewers:

  • Click on the Percy Dashboard link to view detailed visual diffs.
  • Review the visual changes highlighted in the report.
  • Approve or request changes based on the visual differences.

github-actions[bot] avatar Jun 09 '25 19:06 github-actions[bot]

Thanks for review @BabyElias :)

MisRob avatar Jun 09 '25 19:06 MisRob