kolibri-design-system icon indicating copy to clipboard operation
kolibri-design-system copied to clipboard

VISUAL TEST FOR KBREADCRUMBS

Open RONAK-AI647 opened this issue 10 months ago • 7 comments

Description

Changelog

  • Description: Visual Test for KBreadcrumbs
  • Products impact: no
  • Addresses: Issue-924
  • Components: KBreadcrumbs
  • Breaking: no
  • Impacts a11y: no
  • Guidance: Visual Test using Percy

KBreadcrumbs should have visual tests to cover at least these snapshots:

1)Breadcrumbs with just one item (with/without showSingleItem). 2)Breadcrumbs with multiple items that do not overflow the available width. 3)Breadcrumbs with multiple items that overflow the available width. 4)Breadcrumbs with multiple items that have long text. 5)Breadcrumbs with links. 6)Dropdown open for overflowed breadcrumbs with links. 7)Dropdown open for overflowed breadcrumbs without links.

(optional) Implementation notes

At a high level, how did you implement this?

Does this introduce any tech-debt items?

Testing checklist

  • [ ] Contributor has fully tested the PR manually
  • [ ] If there are any front-end changes, before/after screenshots are included
  • [ ] Critical and brittle code paths are covered by unit tests
  • [ ] The change is described in the changelog section above

Reviewer guidance

  • [ ] Is the code clean and well-commented?
  • [ ] Are there tests for this change?
  • [ ] Are all UI components LTR and RTL compliant (if applicable)?
  • [ ] Add other things to check for here

Comments

RONAK-AI647 avatar Feb 11 '25 10:02 RONAK-AI647

There is one change which I have postponed right now , that is changing the Kbreadcrumbs.vue to index.vue .......Soon with the first review , I will commit that too...Thank You.

RONAK-AI647 avatar Feb 11 '25 10:02 RONAK-AI647

Hi @RONAK-AI647, thank you.

There is one change which I have postponed right now , that is changing the Kbreadcrumbs.vue to index.vue .......Soon with the first review , I will commit that too...Thank You.

No problem, let us know when it's ready and I will then add reviewers.

MisRob avatar Feb 12 '25 14:02 MisRob

Hey @AlexVelezLl , May I get a review , I commited few more errors.

RONAK-AI647 avatar Feb 14 '25 14:02 RONAK-AI647

Hi @RONAK-AI647, I will assign reviewers sometime this week. Thank you.

MisRob avatar Feb 17 '25 03:02 MisRob

Thank you @EshaanAgg, we appreciate your help with reviews. @RONAK-AI647 I would welcome if you followed @EshaanAgg's guidance, it's good suggestions.

MisRob avatar Feb 17 '25 19:02 MisRob

Thank You so much , @EshaanAgg , I was a bit engaged my to my jee exams, will return with the possible outcomes according to your instructions , thanks @MisRob , will follow @EshaanAgg 's review.

RONAK-AI647 avatar Feb 23 '25 14:02 RONAK-AI647

Thanks @RONAK-AI647, take all the time you need. Good luck with exams!

MisRob avatar Feb 25 '25 08:02 MisRob

Hi @RONAK-AI647, do you still plan to complete resolving the feedback?

MisRob avatar May 22 '25 03:05 MisRob

Closing in favor of #998

AlexVelezLl avatar Jun 03 '25 15:06 AlexVelezLl