VISUAL TEST FOR KBREADCRUMBS
Description
Changelog
- Description: Visual Test for KBreadcrumbs
- Products impact: no
- Addresses: Issue-924
- Components: KBreadcrumbs
- Breaking: no
- Impacts a11y: no
- Guidance: Visual Test using Percy
KBreadcrumbs should have visual tests to cover at least these snapshots:
1)Breadcrumbs with just one item (with/without showSingleItem). 2)Breadcrumbs with multiple items that do not overflow the available width. 3)Breadcrumbs with multiple items that overflow the available width. 4)Breadcrumbs with multiple items that have long text. 5)Breadcrumbs with links. 6)Dropdown open for overflowed breadcrumbs with links. 7)Dropdown open for overflowed breadcrumbs without links.
(optional) Implementation notes
At a high level, how did you implement this?
Does this introduce any tech-debt items?
Testing checklist
- [ ] Contributor has fully tested the PR manually
- [ ] If there are any front-end changes, before/after screenshots are included
- [ ] Critical and brittle code paths are covered by unit tests
- [ ] The change is described in the changelog section above
Reviewer guidance
- [ ] Is the code clean and well-commented?
- [ ] Are there tests for this change?
- [ ] Are all UI components LTR and RTL compliant (if applicable)?
- [ ] Add other things to check for here
Comments
There is one change which I have postponed right now , that is changing the Kbreadcrumbs.vue to index.vue .......Soon with the first review , I will commit that too...Thank You.
Hi @RONAK-AI647, thank you.
There is one change which I have postponed right now , that is changing the Kbreadcrumbs.vue to index.vue .......Soon with the first review , I will commit that too...Thank You.
No problem, let us know when it's ready and I will then add reviewers.
Hey @AlexVelezLl , May I get a review , I commited few more errors.
Hi @RONAK-AI647, I will assign reviewers sometime this week. Thank you.
Thank you @EshaanAgg, we appreciate your help with reviews. @RONAK-AI647 I would welcome if you followed @EshaanAgg's guidance, it's good suggestions.
Thank You so much , @EshaanAgg , I was a bit engaged my to my jee exams, will return with the possible outcomes according to your instructions , thanks @MisRob , will follow @EshaanAgg 's review.
Thanks @RONAK-AI647, take all the time you need. Good luck with exams!
Hi @RONAK-AI647, do you still plan to complete resolving the feedback?
Closing in favor of #998