learningequality
[KListWithOverflow]: Add unit tests
❌ This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues.
Product
KDS.
Desired behavior
We should add unit tests to KListWithOverflow, since it has some complicated calculations and needs to be protected from regressions. So we need to test at least the following things:
- It should render the whole list items if it fits in the available space, even if there is just 1px of difference.
- It shouldnt render the
moreslot if the list items fits in the available space. - It shouldnt render the items that are overflowed and dont fit in the available space even if there is just 1px of difference.
- It should render the
moreslot if there are overflowed items. - It should pass the correct items in the
overflowItemsarray passed to themoreslot. - It shouldnt render a divider as the last item in the visible list, even if it fits in the available space.
Current behavior
We currently dont have unit tests for KListWithOverflow.
Hi @AlexVelezLl , I would like to work on this issue. Please assign to me.
Hey @yeshwanth235 thank you for your interest in handling this issue, I can assign it to you. Please let us know if you have any questions! :)
Hey @AlexVelezLl , I would like to work on this issue. If no one is working on this, please assign this to me.
Hey @you-think-you-know-me, thanks for your interest in contributing to LE!
As we haven't had any activity from the currently assigned contributor in two months, I will reassign this issue to you :). Please let us know if you have any questions!
Hi @VincentChiang621! Thanks for your interest in contributing to Learning Equality! I will assign this to you :). Please, take into account the conversations we had in this closed PR for you to have some hints for this issue. If you have any question, please let us know!