kolibri-design-system
kolibri-design-system copied to clipboard
Refactor KBreadcrumbs to utilize KListWithOverflow
Description
Task1
- Added OverFlowDirection Prop for the kListwithoverflow component Task2
- Updated KBreadcrums to use KListWithOverflow.
Issue addressed
Addresses #693.
Before/after screenshots
Changelog
- Description: Summary of change(s)
- Products impact: Choose from - none (for internal updates) / bugfix / new API / updated API / removed API. If it's 'none', use "-" for all items below to indicate they are not relevant.
- Addresses: Link(s) to GH issue(s) addressed. Include KDS links as well as links to related issues in a consumer product repository too.
- Components: Affected public KDS component. Do not include internal sub-components or documentation components.
- Breaking: Will this change break something in a consumer? Choose from: yes / no
- Impacts a11y: Does this change improve a11y or adds new features that can be used to improve it? Choose from: yes / no
- Guidance: Why and how to introduce this update to a consumer? Required for breaking changes, appreciated for changes with a11y impact, and welcomed for non-breaking changes when relevant.
Steps to test
- Step 1
- Step 2
- ...
(optional) Implementation notes
At a high level, how did you implement this?
Does this introduce any tech-debt items?
Testing checklist
- [ ] Contributor has fully tested the PR manually
- [ ] If there are any front-end changes, before/after screenshots are included
- [ ] Critical and brittle code paths are covered by unit tests
- [ ] The change is described in the changelog section above
Reviewer guidance
- [ ] Is the code clean and well-commented?
- [ ] Are there tests for this change?
- [ ] Are all UI components LTR and RTL compliant (if applicable)?
- [ ] Add other things to check for here
Comments
Also, a side note! When we open a PR we should keep and fill the form template that appears when we create the PR, not remove it, I have pasted it again to the PR description :hugs:.
Hey @sruthin21! Are you still interested in continuing working in this issue?
Hi @sruthin21, by deleting your fork, unfortunately we won't be able to finish this PR. I will unassign you from https://github.com/learningequality/kolibri-design-system/issues/693, but feel free to message us and re-open if you'd like.