kolibri-design-system icon indicating copy to clipboard operation
kolibri-design-system copied to clipboard

Make _useKResponsiveElement composable public and Remove KResponsiveElementMixin

Open AlexVelezLl opened this issue 1 year ago • 3 comments

Product

KDS, Kolibri (Studio and KDP doesnt seem to be using the KResponsiveElementMixin).

Description

Transition the internal composable _useKResponsiveElement to a public-facing composable named useKResponsiveElement. Then, remove the KResponsiveElementMixin mixin from the codebase. This involves the following steps:

  • Rename _useKResponsiveElement.js file to useKResponsiveElement.js.
  • Update all internal references to use the new file name.
  • Migrate all internal references of KResponsiveElementMixin to use the new useKResponsiveElement composable.
  • Remove the KResponsiveElementMixin.js file.
  • Create a new documentation page for useKResponsiveElement.
  • Remove the old documentation page of KResponsiveElementMixin.

The Value Add

After this, we will able to replace all KResponsiveElement mixins with this composable. This aligns with our plan of adopting composables over mixins.

AlexVelezLl avatar Aug 01 '24 20:08 AlexVelezLl

hi, @AlexVelezLl can you assign this issue to me?

lokesh-sagi125 avatar Aug 20 '24 06:08 lokesh-sagi125

Hey @lokesh-sagi125, I think the issue is suitable for contribution, however @AlexVelezLl assigned himself some time ago so I'm not sure if there's some work in progress. Let's hear from Alex first where things are.

MisRob avatar Aug 20 '24 09:08 MisRob

Hey @lokesh-sagi125! This issue is already assigned to me, and I have already made some progress :sweat_smile:. But you can always check our list of unassigned "help wanted" or "good first issue" issues across all our repositories :open_hands:.

AlexVelezLl avatar Aug 20 '24 13:08 AlexVelezLl