Add preserveAboveTitle prop for flexible aboveTitle slot management.
…ent should occupy the area designated for it or not
Description
Issue addressed
Addresses #PR# HERE
Before/after screenshots
Changelog
[#705]
- Description: Update
KCardupdates: Add preserveAboveTitle prop for flexible aboveTitle slot management. - Products impact: Card updates
- Addresses: https://github.com/learningequality/kolibri-design-system/issues/702
- Components:
KCard - Breaking: N0
- Impacts a11y: No
- Guidance: [#705] https://github.com/learningequality/kolibri-design-system/pull/705
Steps to test
- Step 1
- Step 2
- ...
(optional) Implementation notes
At a high level, how did you implement this?
Does this introduce any tech-debt items?
Testing checklist
- [ ] Contributor has fully tested the PR manually
- [ ] If there are any front-end changes, before/after screenshots are included
- [ ] Critical and brittle code paths are covered by unit tests
- [ ] The change is described in the changelog section above
Reviewer guidance
- [ ] Is the code clean and well-commented?
- [ ] Are there tests for this change?
- [ ] Are all UI components LTR and RTL compliant (if applicable)?
- [ ] Add other things to check for here
After review
- [ ] The changelog item has been pasted to the
CHANGELOG.md
Comments
Hi @AllanOXDi, now the next step in our row of reviews would be to rebase on the latest develop and double-check all the changes related to slots in this PR after that. Then, please mention me, and I will review. Thanks :)
Hi @AllanOXDi, now the next step in our row of reviews would be to rebase on the latest develop and double-check all the changes related to slots in this PR after that. Then, please mention me, and I will review. Thanks :)
Hi @MisRob We are good to go here.
Also tested in the playground - works like a charm :)