kolibri-design-system icon indicating copy to clipboard operation
kolibri-design-system copied to clipboard

Add preserveAboveTitle prop for flexible aboveTitle slot management.

Open AllanOXDi opened this issue 1 year ago • 3 comments

…ent should occupy the area designated for it or not

Description

Issue addressed

Addresses #PR# HERE

Before/after screenshots

Changelog

[#705]

  • Description: UpdateKCard updates: Add preserveAboveTitle prop for flexible aboveTitle slot management.
  • Products impact: Card updates
  • Addresses: https://github.com/learningequality/kolibri-design-system/issues/702
  • Components: KCard
  • Breaking: N0
  • Impacts a11y: No
  • Guidance: [#705] https://github.com/learningequality/kolibri-design-system/pull/705

Steps to test

  1. Step 1
  2. Step 2
  3. ...

(optional) Implementation notes

At a high level, how did you implement this?

Does this introduce any tech-debt items?

Testing checklist

  • [ ] Contributor has fully tested the PR manually
  • [ ] If there are any front-end changes, before/after screenshots are included
  • [ ] Critical and brittle code paths are covered by unit tests
  • [ ] The change is described in the changelog section above

Reviewer guidance

  • [ ] Is the code clean and well-commented?
  • [ ] Are there tests for this change?
  • [ ] Are all UI components LTR and RTL compliant (if applicable)?
  • [ ] Add other things to check for here

After review

  • [ ] The changelog item has been pasted to the CHANGELOG.md

Comments

AllanOXDi avatar Jul 29 '24 21:07 AllanOXDi

Hi @AllanOXDi, now the next step in our row of reviews would be to rebase on the latest develop and double-check all the changes related to slots in this PR after that. Then, please mention me, and I will review. Thanks :)

MisRob avatar Aug 16 '24 04:08 MisRob

Hi @AllanOXDi, now the next step in our row of reviews would be to rebase on the latest develop and double-check all the changes related to slots in this PR after that. Then, please mention me, and I will review. Thanks :)

Hi @MisRob We are good to go here.

AllanOXDi avatar Aug 19 '24 19:08 AllanOXDi

Also tested in the playground - works like a charm :)

MisRob avatar Aug 20 '24 10:08 MisRob