kolibri-design-system icon indicating copy to clipboard operation
kolibri-design-system copied to clipboard

Add documentation to the KTooltip page

Open MisRob opened this issue 1 year ago • 3 comments

🌱 Are you new to the codebase? Welcome! Please see the contributing guidelines.

Summary

The KTooltip documentation page lacks an overview and examples of usage. The goal of this issue is to:

  • [ ] Add the “Overview” section with a brief introduction on what the component is for.
  • [ ] Add the “Usage” section with sub-sections documenting:
    • [ ] The basic usage with an example code snippet and the visualization of its output. The example should include reference and refs explanation and show how KTooltip is used together with another component, such as KIcon (Kolibri codebase examples).
    • [ ] A visualization of the disabled state
    • [ ] A visualization of all supported placements
    • [ ] A visualization of maxWidth

Guidance

MisRob avatar Jul 26 '24 19:07 MisRob

I want to work on this Issue Please Assign This to me

sruthin21 avatar Sep 12 '24 11:09 sruthin21

Thanks for your interest in picking this up @sruthin21!! I just assigned this issue to you :hugs:. Please let us know if there is anything we can help with :open_hands:.

AlexVelezLl avatar Sep 12 '24 14:09 AlexVelezLl

sure @AlexVelezLl Thanks for assigning

sruthin21 avatar Sep 12 '24 14:09 sruthin21

Work and review in https://github.com/learningequality/kolibri-design-system/pull/789 can serve as a good guidance since that PR nearly finished the issue.

MisRob avatar Dec 02 '24 03:12 MisRob

I want to work on this issue .Can you please assign this to me.

shruti862 avatar Dec 05 '24 14:12 shruti862

Hi @shruti862, sure, thanks! Please read carefully the guidance, comments, and the referenced pull request - you can find all you need there to finish this successfully.

MisRob avatar Dec 06 '24 05:12 MisRob

@MisRob Thank you for assigning the issue ; I have gone through the referenced PR soon I will raise PR.

shruti862 avatar Dec 06 '24 07:12 shruti862

@MisRob Can you please also review this PR ( whenever you get time ) to see if there any more changes needed.

shruti862 avatar Dec 09 '24 09:12 shruti862

Yes, @shruti862, I've just posted a comment there. Thank you.

MisRob avatar Dec 09 '24 09:12 MisRob

@MisRob I did yarn lint-fix for linting issue in the new PR which only contains ktooltip file changes as you suggested ; please review it whenever you get time.

shruti862 avatar Dec 09 '24 12:12 shruti862

Thanks @shruti862

MisRob avatar Dec 09 '24 15:12 MisRob

Closed by https://github.com/learningequality/kolibri-design-system/pull/859

MisRob avatar Dec 16 '24 12:12 MisRob