kolibri-design-system icon indicating copy to clipboard operation
kolibri-design-system copied to clipboard

issue-#10491 Allow moving with arrow keys over radio buttons in firefox

Open muditchoudhary opened this issue 1 year ago • 10 comments

Description

The PR fixed the accessibility issue of arrow keys not working for moving over radio buttons in Firefox.

Issue addressed

Addresses #PR# HERE

Before/after screenshots

https://github.com/learningequality/kolibri-design-system/assets/74391865/c6777cba-6a4e-4808-9428-8eb9d95b3df5

Changelog

  • [#PR no]
    • Description: Summary of change(s)
    • Products impact: Choose from - none (for internal updates) / bugfix / new API / updated API / removed API. If it's 'none', use "-" for all items below to indicate they are not relevant.
    • Addresses: Link(s) to GH issue(s) addressed. Include KDS links as well as links to related issues in a consumer product repository too.
    • Components: Affected public KDS component. Do not include internal sub-components or documentation components.
    • Breaking: Will this change break something in a consumer? Choose from: yes / no
    • Impacts a11y: Does this change improve a11y or adds new features that can be used to improve it? Choose from: yes / no
    • Guidance: Why and how to introduce this update to a consumer? Required for breaking changes, appreciated for changes with a11y impact, and welcomed for non-breaking changes when relevant.

[#PR no]: PR link

Steps to test

  1. Step 1
  2. Step 2
  3. ...

(optional) Implementation notes

At a high level, how did you implement this?

Does this introduce any tech-debt items?

Testing checklist

  • [ ] Contributor has fully tested the PR manually
  • [ ] If there are any front-end changes, before/after screenshots are included
  • [ ] Critical and brittle code paths are covered by unit tests
  • [ ] The change is described in the changelog section above

Reviewer guidance

  • [ ] Is the code clean and well-commented?
  • [ ] Are there tests for this change?
  • [ ] Are all UI components LTR and RTL compliant (if applicable)?
  • [ ] Add other things to check for here

After review

  • [ ] The changelog item has been pasted to the CHANGELOG.md

Comments

muditchoudhary avatar Feb 22 '24 12:02 muditchoudhary