Improved Icons Flow: KDS <> Figma
❌ This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues.
Product
KDS
Desired behavior
Currently we are bundling a couple of sizable libraries from which we pull many of our icons.
However, we also have a Figma handy which includes the SVGs for all of our icons.
We'd like to see that Figma become the KDS "source of truth" for our iconography moving forward.
(Optional) The Value Add
Designers can use Figma to update / add icons and create a new issue in the KDS repo saying "Hey we added these new icons in the Figma, please include these in an upcoming release". This dovetail nicely with our existing engineering workflow, allowing a dev to pick up the issue and make a PR with the new icons' necessary updates.
Also, we'll be able to remove some significant mass from our dev machines' node_modules.
Acceptance criteria
- [ ] @jtamiace and @nucleogenesis to collaborate to identify the workflow (ie, how we will get the icons out of Figma into the devs' hands in as streamlined a manner as we can manage)
- [ ] Document that process - this could be added to a README file in the KDS repo for posterity as well -- in any case, make this as easy a process as possible for future designers and devs who might try to take on this task.
- [ ] Perform the initial migration - remove the unused dependencies, ensure all icons are in the
custom-iconsdirectory, make a PR, get QA on the PR ensuring that icons still work in products (although we may do well to diff the HTML on the icons page in the KDS docs before and after the changes... if there are no errors there, should be good).
Document that process - this could be added to a README file in the KDS repo for posterity as well -- in any case, make this as easy a process as possible for future designers and devs who might try to take on this task.
This is the page to be updated: https://github.com/learningequality/kolibri-design-system/blob/main/dev_docs/05_icons.md.
@nucleogenesis I needed to add a new icon today and wanted to write guidance for it that I could reference for contributors. It was easier and more clear to remove parts that will soon be obsolete right away, so I did that. In a way, it prepares ground for the documentation acceptance criteria of this work as well https://github.com/learningequality/kolibri-design-system/pull/542