kolibri-design-system
kolibri-design-system copied to clipboard
CSV import supports email address as identifier but Users list UI doesn't render it properly
Observed behavior
CSV import instructions at Facility - DATA - Import and export users - View spreadsheet format reference suggests using email address as an Identifier -

But an email address overlaps with gender field even for short emails in the Facility - USERS list -

Expected behavior
Identifier field's value should not overlap with gender field value.
User-facing consequences
Unreadable data
Errors and logs
…
Steps to reproduce
…
Context
Kolibri 0.14.0
@intelliant01 could you elaborate a bit more where is the issue? I don't quite understand it. If you could attach a csv to test it, it would be great.
@jredrejo This isn't an issue with CSV import, it's just that the Identifier column on the 'Facility > User' field has a max-width of 120px, which isn't wide enough for long email addresses.
https://github.com/learningequality/kolibri/blob/0beb63c921f4568a228c03fb96f444319818016d/kolibri/plugins/facility/assets/src/views/UserTable.vue#L265-L268
@jredrejo the issue is not per se with the CSV import process. Just edit a user's profile and set an average length email address and choose a gender for any user and we have the email address and gender values overlapping.
I am referring to the CSV import because it is only in those instructions that it suggests using an email id for the identifier field.
@radinamatic this one seems to be resolved in 0.15.6 as a slider is displayed if the value is too long:

Closing as fixed.
@rtibbles actually we were just discussing with Radina that this one is still not fixed in Firefox and IE so it should be reopened:
IE11:
Firefox:

Still a few bumps remain to flatten...
Ahah.
@radinamatic this is still a valid issue for Firefox in 0.16.b10 but only when the email is long and the resolution is less than 900 px so it can probably be closed as a rare edge case with no significant impact.
I'm thinking this might be a valid test case for when we approach the feature of the responsive and accessible tables... 🤔 cc @marcellamaki
@radinamatic yes, good idea. it does seem like something that we could consider and test for that feature, but I'm not sure that keeping this issue in particular open will help me remember. Let me think about where we can document that so we remember!
Transferring issue to KDS so that we can track as part of the KSortableTable project