learningequality
Design system not mobile responsive
I went to show my wife the design principles on my phone and it looked like this.
indeed.
the ugly part in the bottom is covered separately by https://github.com/learningequality/kolibri-design-system/issues/100
hii, I was wondering if I could be assigned to this issue? I'd be glad to help here :)
Hi @practicatto, that'd be great improvement, thank you. Let me check briefly with our designers to confirm what's expected experience.
@practicatto There will be larger re-design coming but we don't know exactly when and think that it shouldn't block this work. Our design team confirmed that we start with the same experience of side navigation panel as in Kolibri:
I can assign you if you confirm you'd like to implement this.
Thanks @FidalMathew. The expected behavior is best described in https://github.com/learningequality/kolibri-design-system/issues/107#issuecomment-2052131370. Please let me know if it's clear.
@MisRob Would this design work? and on clicking this, we'll be able to view the side nav. Any suggestions?
Hey @FidalMathew! It seems to me that the icon is a little big, what Icon are you using for this? Could you open a PR to have a better sense of the change and discuss better there, plase? :)
@AlexVelezLl I didn't make much changes, just a few minute changes to know where the content is, and some changes are made using inspect element. The image is a photoshopped to place for now. Any suggestions on where to get icons from?
You can use our KIcon component, and use our menu icon https://design-system.learningequality.org/icons/#token-menu, here you can see an example: https://github.com/AlexVelezLl/kolibri-design-system/blob/ab6dc8f06c89e78887bd686fa1ba8e707db43a05/docs/common/DocsToggleButton.vue#L4
Hi @FidalMathew, are you still planning to work on this issue or should we unassign?
@MisRob Sorry, I have been sick lately, I would like to continue working on this issue.
Hi @FidalMathew, first of all I hope you get well soon.
No worries about the issue at all! Please take all the time you need, we will keep you assigned. I am just doing my regular check-in rounds on possibly stale issues.
Hi @FidalMathew, I wanted to mention that Learning Equality will be closed from December 23 to January 5.
Hi @Flying-Pegasus - this issue has already been assigned and as of now is being worked on by another contributor. If it becomes available we will let you know.
Closed by https://github.com/learningequality/kolibri-design-system/pull/862, thanks a lot @FidalMathew, we appreciate it.
@nucleogenesis
I went to show my wife the design principles on my phone and it looked like this.
time to show your wife again!