ka-lite icon indicating copy to clipboard operation
ka-lite copied to clipboard

Untranslated exercise - orange dot

Open radinamatic opened this issue 8 years ago • 18 comments

Summary

@benjaoming fixed #5105 so the infamous line with orange dot is displayed correctly with UI in English, but fails in other languages.

Possibly related to #5107 or #5114 @rtibbles?

Branch or installer method

0.16.5 on Ubuntu 16.04

Traceback

Invalid number line configuration error in this exercise: and the following in Console:

Warning: Failed propType: Required prop `numLinePosition` was not specified in `NumberLine`. Check the render method of `WidgetContainer`.

Screenshots

Spanish:

ubuntu16 ready running - oracle vm virtualbox_438

Portuguese:

ubuntu16 ready running - oracle vm virtualbox_439

radinamatic avatar May 06 '16 12:05 radinamatic

passing the ball to rtibbles so he can rdribbles it up midfield as the playmaker.. then choose the pass or to go straight for goal..

benjaoming avatar May 06 '16 13:05 benjaoming

Need this resolved for 0.16.6 either as a known issue or as a fix.

benjaoming avatar May 06 '16 13:05 benjaoming

Confirmed on 0.16.5 (build 228) on Windows 7: same error in Spanish, all OK in English.

radinamatic avatar May 06 '16 19:05 radinamatic

This may be because the Spanish version is using Perseus, but the English is using Khan Exercises?

@aronasorman Might know more here.

rtibbles avatar May 06 '16 21:05 rtibbles

@rtibbles on the right track: English version of this exercise is calling static/js/distributed/perseus/ke/exercises/number_line.html?_=1462829070370, and if I switch to Spanish from there I get the Unavailable Content message:

ie11 - win7 ready running - oracle vm virtualbox_444

Probably because there does not seem to be a folder es with the translated set of HTML templates in Spanish for those Khan Exercises. Is that supposed to be in the Spanish contentpack @aronasorman?

However, if I start navigating the sidebar in Spanish from the beginning, and select this same exercise, there is no Unavailable Content message, but the result is the first screenshot above with Invalid number line configuration.

On the other hand this does not explain other exercises that still display in English: so far all the exercises in the Early Math topic that I checked make a call to the 'assessment_item' api endpoint, which would make them Perseus exercises, thus non dependent on the missing Khan HTML templates.

radinamatic avatar May 09 '16 21:05 radinamatic

Re-tested this on all the platforms with newly built es contentpack after the PR #25 by @rtibbles was merged, but it did not solve the issue. Basically all the above reported problems still stand, together with untranslated exercises reported in #5107.

@aronasorman

radinamatic avatar May 17 '16 22:05 radinamatic

sigh I don't know where this is happening then :/

rtibbles avatar May 17 '16 22:05 rtibbles

I don't recall where those folders used to be in previous releases, but in 0.16 we have:

  • all the English HTML templates for Khan Exercises in static/js/distributed/perseus/ke/exercises/
  • an empty static/js/distributed/perseus/ke/exercises/en folder and
  • no static/js/distributed/perseus/ke/exercises/es or any other language folder.

Is that the correct folder/HTML templates situation?

radinamatic avatar May 17 '16 22:05 radinamatic

Pinging @aronasorman to look at the above when he gets back!

radinamatic avatar May 19 '16 11:05 radinamatic

@radinamatic @aronasorman any update on the issues....

rifatbd avatar Jun 07 '16 05:06 rifatbd

Latest Spanish contentpack solved most of the exercises that were not displaying correctly, but this error remains the same @aronasorman.

radinamatic avatar Jun 07 '16 13:06 radinamatic

@radinamatic any luck if you try this with the latest ka-lite-bundle in the ka-lite-proposed PPA?

benjaoming avatar Jun 13 '16 11:06 benjaoming

@benjaoming @radinamatic any update on the issue?

  • The number line is shown properly if we don't have to do any operation on the line... e.g. sdgdsf
  • But it is broken when we have to answer using the number line.. e.g. sdfzdf

this link has some exercise like these /learn/khan/math/pre-algebra/negatives-absolute-value-pre-alg/add-sub-negatives-pre-alg/number_line_2

rifatbd avatar Jul 20 '16 09:07 rifatbd

@radinamatic any updates on this as per my latest comment? :)

benjaoming avatar Jul 27 '16 23:07 benjaoming

Alas, @benjaoming, on the latest 0.16.7 prerelease I tested on Windows last week it was still present... :cry:

radinamatic avatar Jul 28 '16 17:07 radinamatic

I'm afraid this issue is not seeing enough progress to be fixed in a 0.16 patch release, let's postpone it for 0.17.

The vast amount of exercises have already been fixed, so it's okay to relax and enjoy that, too :)

There is a window open for 0.16.8, and anyone who wants to jump in and get this fixed quickly should feel encouraged to do so.. otherwise, there's another bigger issue for 0.16.8 that should have more priority.

benjaoming avatar Aug 01 '16 13:08 benjaoming

@radinamatic this still happens for /learn/khan/math/pre-algebra/negatives-absolute-value-pre-alg/add-sub-negatives-pre-alg/number_line_2 in Spanish.

Since Spanish decimal numbers are seperated by commas, I suspect that the Invalid number line configuration error message could be caused by this...

benjaoming avatar Dec 17 '16 00:12 benjaoming

I can confirm that... Tried changing the decimal point in the Settings, but error is still there. Maybe it's not immediate and something else is required too...

virtualbox_windows 7_19_12_2016_15_56_48

radinamatic avatar Dec 19 '16 14:12 radinamatic