LearnCard icon indicating copy to clipboard operation
LearnCard copied to clipboard

Oxlint

Open TaylorBeeston opened this issue 5 months ago โ€ข 6 comments
trafficstars

Overview

๐ŸŽŸ Relevant Jira Issues

๐Ÿ“š What is the context and goal of this PR?

This PR replaces ESLint with Oxlint! =) (https://oxc.rs/docs/guide/usage/linter.html)

๐Ÿฅด TL; RL:

Claude Code and I went through and deleted all ESLint stuff and replaced it with Oxlint! I then ran the linter through the whole repo and fixed all lint errors/warnings!

๐Ÿ’ก Feature Breakdown (screenshots & videos encouraged!)

๐Ÿ›  Important tradeoffs made:

You'll need to set up support for Oxlint in your editor! I think we all use VSCode/a fork of it now, so it should auto-prompt you when you check out this PR. I haven't set up oxlint in neovim yet, so no help there (yet).

๐Ÿ” Types of Changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x] Chore (refactor, documentation update, etc)

๐Ÿ’ณ Does This Create Any New Technical Debt? ( If yes, please describe and add JIRA TODOs )

  • [x] No
  • [ ] Yes

Testing

๐Ÿ”ฌ How Can Someone QA This?

pnpm i && pnpm lint

๐Ÿ“ฑ ๐Ÿ–ฅ Which devices would you like help testing on?

๐Ÿงช Code Coverage

No new tests, but all current tests pass!

Documentation

๐Ÿ“œ Gitbook

๐Ÿ“Š Storybook

โœ… PR Checklist

  • [ ] Related to a Jira issue (create one if not)
  • [x] My code follows style guidelines (eslint / prettier)
  • [x] I have manually tested common end-2-end cases
  • [x] I have reviewed my code
  • [x] I have commented my code, particularly where ambiguous
  • [x] New and existing unit tests pass locally with my changes
  • [x] I have made corresponding changes to gitbook documentation

๐Ÿš€ Ready to squash-and-merge?:

  • [x] Code is backwards compatible
  • [x] There is not a "Do Not Merge" label on this PR
  • [x] I have thoughtfully considered the security implications of this change.
  • [x] This change does not expose new public facing endpoints that do not have authentication

TaylorBeeston avatar Jun 18 '25 05:06 TaylorBeeston

๐Ÿฆ‹ Changeset detected

Latest commit: 188e983c5e82d1e6ed7fc885d86f6a57d2951cce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 38 packages
Name Type
@learncard/simple-signing-service Patch
@learncard/simple-signing-client Patch
@learncard/learn-cloud-service Patch
@learncard/network-brain-service Patch
@learncard/network-brain-client Patch
@learncard/learn-cloud-client Patch
@learncard/simple-signing-plugin Patch
@learncard/network-plugin Patch
@learncard/claimable-boosts-plugin Patch
@learncard/create-http-bridge Patch
@learncard/did-web-plugin Patch
@learncard/dynamic-loader-plugin Patch
learn-card-discord-bot Patch
@learncard/vc-templates-plugin Patch
@learncard/learn-cloud-plugin Patch
@learncard/snap-chapi-example Patch
@learncard/helpers Patch
@learncard/encryption-plugin Patch
@learncard/expiration-plugin Patch
@learncard/learn-card-plugin Patch
@learncard/snap-example-dapp Patch
@learncard/types Patch
@learncard/ethereum-plugin Patch
@learncard/react Patch
@learncard/core Patch
@learncard/init Patch
@learncard/ceramic-plugin Patch
@learncard/crypto-plugin Patch
@learncard/didkey-plugin Patch
@learncard/didkit-plugin Patch
@learncard/vc-api-plugin Patch
@learncard/meta-mask-snap Patch
@learncard/chapi-example Patch
@learncard/chapi-plugin Patch
@learncard/vpqr-plugin Patch
@learncard/idx-plugin Patch
@learncard/vc-plugin Patch
@learncard/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jun 18 '25 05:06 changeset-bot[bot]

Deploy Preview for learn-card-chapi-example failed. Why did it fail? โ†’

Name Link
Latest commit 188e983c5e82d1e6ed7fc885d86f6a57d2951cce
Latest deploy log https://app.netlify.com/projects/learn-card-chapi-example/deploys/68531742b5b6cb0008daace7

netlify[bot] avatar Jun 18 '25 05:06 netlify[bot]

Deploy Preview for learncarddocs canceled.

Name Link
Latest commit 188e983c5e82d1e6ed7fc885d86f6a57d2951cce
Latest deploy log https://app.netlify.com/projects/learncarddocs/deploys/685317422b6c7d0008e8d171

netlify[bot] avatar Jun 18 '25 05:06 netlify[bot]

This PR is missing a Jira ticket reference in the title or description. Please add a Jira ticket reference to the title or description of this PR.

gitstream-cm[bot] avatar Jun 18 '25 05:06 gitstream-cm[bot]

This PR is missing a Jira ticket reference in the title or description. Please add a Jira ticket reference to the title or description of this PR.

gitstream-cm[bot] avatar Jun 18 '25 05:06 gitstream-cm[bot]

This PR is missing a Jira ticket reference in the title or description. Please add a Jira ticket reference to the title or description of this PR.

gitstream-cm[bot] avatar Jun 18 '25 05:06 gitstream-cm[bot]