LearnCard icon indicating copy to clipboard operation
LearnCard copied to clipboard

Bump credential-handler-polyfill version

Open TaylorBeeston opened this issue 1 year ago โ€ข 3 comments

Overview

๐ŸŽŸ Relevant Jira Issues

๐Ÿ“š What is the context and goal of this PR?

There is a recent, serious breaking issue that is occuring due to CHAPI's credential-handler-polyfill patching navigator.credentials.get. We have "fixed" this already by wrapping it in a try/catch, but upstream they have actually fixed it using a Proxy.

๐Ÿฅด TL; RL:

Bumps to latest credential-handler-polyfill version to fix the above issue

๐Ÿ’ก Feature Breakdown (screenshots & videos encouraged!)

๐Ÿ›  Important tradeoffs made:

๐Ÿ” Types of Changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x] Chore (refactor, documentation update, etc)

๐Ÿ’ณ Does This Create Any New Technical Debt? ( If yes, please describe and add JIRA TODOs )

  • [x] No
  • [ ] Yes

Testing

๐Ÿ”ฌ How Can Someone QA This?

Confirm you have a browser that was broken before by linking @learncard/init to LCA, removing the try/catch around the loadOnce call in the CHAPI plugin, lowering the version of credential-handler-polyfill in the CHAPI plugin to 3.2.0, then rebuilding the CHAPI plugin and @learncard/init. You should see the wallet fail to initialize. If you do, then bump credential-handler-polyfill back to 3.2.1 and try it. It should now work!

๐Ÿ“ฑ ๐Ÿ–ฅ Which devices would you like help testing on?

๐Ÿงช Code Coverage

Documentation

๐Ÿ“œ Gitbook

๐Ÿ“Š Storybook

โœ… PR Checklist

  • [ ] Related to a Jira issue (create one if not)
  • [x] My code follows style guidelines (eslint / prettier)
  • [x] I have manually tested common end-2-end cases
  • [x] I have reviewed my code
  • [ ] I have commented my code, particularly where ambiguous
  • [x] New and existing unit tests pass locally with my changes
  • [ ] I have made corresponding changes to gitbook documentation

๐Ÿš€ Ready to squash-and-merge?:

  • [x] Code is backwards compatible
  • [x] There is not a "Do Not Merge" label on this PR
  • [x] I have thoughtfully considered the security implications of this change.
  • [x] This change does not expose new public facing endpoints that do not have authentication

TaylorBeeston avatar Jun 13 '24 18:06 TaylorBeeston

Actual table here: https://github.com/adaptive-learning/iticse-2024-defects-catalog

acbart avatar Jul 08 '24 09:07 acbart