Bump credential-handler-polyfill version
Overview
๐ Relevant Jira Issues
๐ What is the context and goal of this PR?
There is a recent, serious breaking issue that is occuring due to CHAPI's credential-handler-polyfill
patching navigator.credentials.get. We have "fixed" this already by wrapping it in a try/catch,
but upstream they have actually fixed it using a Proxy.
๐ฅด TL; RL:
Bumps to latest credential-handler-polyfill version to fix the above issue
๐ก Feature Breakdown (screenshots & videos encouraged!)
๐ Important tradeoffs made:
๐ Types of Changes
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [x] Chore (refactor, documentation update, etc)
๐ณ Does This Create Any New Technical Debt? ( If yes, please describe and add JIRA TODOs )
- [x] No
- [ ] Yes
Testing
๐ฌ How Can Someone QA This?
Confirm you have a browser that was broken before by linking @learncard/init to LCA, removing the
try/catch around the loadOnce call in the CHAPI plugin, lowering the version of credential-handler-polyfill
in the CHAPI plugin to 3.2.0, then rebuilding the CHAPI plugin and @learncard/init. You should see
the wallet fail to initialize. If you do, then bump credential-handler-polyfill back to 3.2.1
and try it. It should now work!
๐ฑ ๐ฅ Which devices would you like help testing on?
๐งช Code Coverage
Documentation
๐ Gitbook
๐ Storybook
โ PR Checklist
- [ ] Related to a Jira issue (create one if not)
- [x] My code follows style guidelines (eslint / prettier)
- [x] I have manually tested common end-2-end cases
- [x] I have reviewed my code
- [ ] I have commented my code, particularly where ambiguous
- [x] New and existing unit tests pass locally with my changes
- [ ] I have made corresponding changes to gitbook documentation
๐ Ready to squash-and-merge?:
- [x] Code is backwards compatible
- [x] There is not a "Do Not Merge" label on this PR
- [x] I have thoughtfully considered the security implications of this change.
- [x] This change does not expose new public facing endpoints that do not have authentication
Actual table here: https://github.com/adaptive-learning/iticse-2024-defects-catalog