lean4 icon indicating copy to clipboard operation
lean4 copied to clipboard

fix: finalize libuv

Open eric-wieser opened this issue 8 months ago • 4 comments

This PR ensures that libuv objects are cleaned up by finalize_runtime_module().

Closes #7753

eric-wieser avatar Mar 31 '25 11:03 eric-wieser

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 797b0e2c621d1c9513fefc98429c80f632ea8328 --onto 2edfe2e9cffd55e3c79291628ae091b942291ec9. You can force Mathlib CI using the force-mathlib-ci label. (2025-04-01 13:38:59)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase c658648ee8923a66ce3ff8bb79bbd4550dbb10b4 --onto 1ee7e1a9d8a67d1d8dcf6a17ac5c92bc2c7e0fac. You can force Mathlib CI using the force-mathlib-ci label. (2025-04-03 17:58:20)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 3452a8a2e5744b9efb4ed1a4877e2bc0b169e210 --onto 0f4459b42c87d7712391e6d87160da3077fff671. You can force Mathlib CI using the force-mathlib-ci label. (2025-06-03 21:23:53)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 9afe5ccae3a4b7d5e49dc73a4089de64570282b9 --onto 0f4459b42c87d7712391e6d87160da3077fff671. You can force Mathlib CI using the force-mathlib-ci label. (2025-06-03 22:41:02)

I think that this PR will probably close #7753 right? Would you mind if I make some modifications to your PR to address the remaining problems?

algebraic-dev avatar Apr 01 '25 16:04 algebraic-dev

@algebraic-dev, I am very happy for you to take over here!

eric-wieser avatar Apr 01 '25 17:04 eric-wieser

I was trying to run the initializers and finalizers in an infinite loop, and sometimes it gives me a segfault. I changed the lthread call to a pthread call just to check if it was related, and it seems like it is. when I'm using raw pthreads, it just doesn't segfault.

algebraic-dev avatar Jun 03 '25 20:06 algebraic-dev