lean4 icon indicating copy to clipboard operation
lean4 copied to clipboard

feat: add BitVec.ult/ule_ofNat

Open bollu opened this issue 1 year ago • 5 comments

This supersedes https://github.com/leanprover/std4/pull/664, and adds lemmas that mirror ofNat_{add,sub}_ofNat for ult, ule.

bollu avatar Feb 22 '24 01:02 bollu

Mathlib CI status (docs):

  • ❗ Std/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase b6ed97bb3dad824d3c1fc82dbf290ef0505c42d0 --onto 6719af350fde9339354f28d091458df39a4af9d4. (2024-02-22 02:08:35)

awaiting-review

bollu avatar Feb 24 '24 17:02 bollu

I don't think either of these should be simp rules. There is active work on integrating SAT solving into Lean, and in the ground case, I think it'd be useful to keep the Bitvec types around.

joehendrix avatar Feb 26 '24 23:02 joehendrix

They're no longer simp lemmas.

bollu avatar Jun 06 '24 14:06 bollu

awaiting-review

bollu avatar Jun 06 '24 14:06 bollu