lean4 icon indicating copy to clipboard operation
lean4 copied to clipboard

chore: make IO.RealWorld opaque

Open kim-em opened this issue 2 years ago • 7 comments

kim-em avatar Oct 11 '23 02:10 kim-em

Do the test diffs imply we're doing more refcounting? !bench (edit: ugh, I can never remember which commands work as part of a larger comment)

Kha avatar Oct 11 '23 08:10 Kha

!bench

Kha avatar Oct 11 '23 09:10 Kha

Here are the benchmark results for commit fafd028e5c3d7fe1ad0128688a355af312487fbc. There were no significant changes against commit 0700925bbeb86c7b883719a82241595f5f905e5c.

leanprover-bot avatar Oct 11 '23 09:10 leanprover-bot

@Kha, do you think this is okay to merge, given that benchmarking was okay?

kim-em avatar Oct 15 '23 01:10 kim-em

@Kha, do you think this is okay to merge, given that benchmarking was okay?

Yes! Sorry for the 13-month delay :)

Kha avatar Nov 22 '24 15:11 Kha

I don't think this is really blocked by the new code generator.

zwarich avatar Mar 09 '25 20:03 zwarich

Closing this in favor of #9631.

zwarich avatar Sep 07 '25 17:09 zwarich