lean4
lean4 copied to clipboard
connect maxHeartbeats in CoreM to kernel variable max_heartbeats
Thanks for your contribution! Please make sure to follow our Commit Convention.
The basic approach looks good (assuming it works :) ). Is there anything left to do apart from cleaning up the PR?
I didn't run the test suite while I was at the hackathon since my laptop is quite small :) On coming back home and running the test suite, I find a large number of tests break:
https://gist.github.com/bollu/f8608a2849bde346c64d7f6ebb10ca71
I'll be debugging this tomorrow, but if anyone has any quick guesses as to why this might be the case, I'd appreciate it!
For "quick guesses", --output-on-failure
would have been helpful :) . And the CI won't run until you address the merge conflicts.
@bollu Are you still planning to work on this PR, or should I close it?
@leodemoura Closed to clear Lean's PR queue; I shall send a completed PR once the solution does not fail on seemingly unrelated test cases.