lean4 icon indicating copy to clipboard operation
lean4 copied to clipboard

connect maxHeartbeats in CoreM to kernel variable max_heartbeats

Open bollu opened this issue 2 years ago • 4 comments

bollu avatar Jul 22 '22 19:07 bollu

Thanks for your contribution! Please make sure to follow our Commit Convention.

github-actions[bot] avatar Jul 22 '22 19:07 github-actions[bot]

The basic approach looks good (assuming it works :) ). Is there anything left to do apart from cleaning up the PR?

Kha avatar Jul 25 '22 07:07 Kha

I didn't run the test suite while I was at the hackathon since my laptop is quite small :) On coming back home and running the test suite, I find a large number of tests break:

https://gist.github.com/bollu/f8608a2849bde346c64d7f6ebb10ca71

I'll be debugging this tomorrow, but if anyone has any quick guesses as to why this might be the case, I'd appreciate it!

bollu avatar Jul 28 '22 01:07 bollu

For "quick guesses", --output-on-failure would have been helpful :) . And the CI won't run until you address the merge conflicts.

Kha avatar Jul 28 '22 08:07 Kha

@bollu Are you still planning to work on this PR, or should I close it?

leodemoura avatar Sep 03 '22 15:09 leodemoura

@leodemoura Closed to clear Lean's PR queue; I shall send a completed PR once the solution does not fail on seemingly unrelated test cases.

bollu avatar Sep 05 '22 16:09 bollu