lake icon indicating copy to clipboard operation
lake copied to clipboard

No distinction between warnings/errors from project and its dependencies

Open kim-em opened this issue 3 years ago • 1 comments

When lake is building a dependent package, could we have error messages prefixed by the package being built?

e.g. I was just updating mathport to the new package foo { ... } syntax, and when I had updated the main lakefile.lean but not the subsidiary ones, the only error I get is build error: configuration file is missing a package declaration.

kim-em avatar Oct 06 '21 02:10 kim-em

This is non-trivial to add, but it is a good suggestion and something I will put on my TODO list.

Ironically, doing this for the example you mentioned (i.e., package configuration errors) would be the hardest, because it isn't necessarily know what package is being built until after the configuration file in question is successfully read.

Errors with the build error prefix in general are also hard, because that means that it was the error caught by the final catch all error reporter (where the actual source of the error has long been lost).

However, as I refactoring things, this all may get easier in which case I will certainly keep this in mind as something to integrated into such changes.

tydeu avatar Oct 06 '21 02:10 tydeu