LNSym icon indicating copy to clipboard operation
LNSym copied to clipboard

WIP: feat: integrate simp_mem with sym_n

Open alexkeizer opened this issue 1 year ago • 5 comments

Description:

This PR is stacked on #222.

This PR starts the integration, by adding a call to simp_mem to the effect aggregation post-processing step of sym_n.

Testing:

What tests have been run? Did make all succeed for your changes? Was conformance testing successful on an Aarch64 machine?

Yes, make all succeeds.

License:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

NOTE: this PR is owned by @bollu, I (alex) merely opened it because we started pairing on my machine

alexkeizer avatar Sep 23 '24 19:09 alexkeizer

@bollu

alexkeizer avatar Sep 23 '24 19:09 alexkeizer

@alexkeizer comment addressed!

bollu avatar Sep 26 '24 15:09 bollu

@alexkeizer is this an LGTM from you?

bollu avatar Sep 26 '24 15:09 bollu

@alexkeizer @bollu Converting to draft until comments are resolved.

shigoel avatar Sep 30 '24 15:09 shigoel

@bollu I separated out the MemoryEffects structure refactor into its own PR, without the simp_mem call at the end of sym_n (which is still in the current PR), because I don't think the latter is quite ready to be merged yet.

alexkeizer avatar Oct 07 '24 21:10 alexkeizer