mathlib4 icon indicating copy to clipboard operation
mathlib4 copied to clipboard

feat(to_dual): don't translate the order on `Set`

Open JovanGerb opened this issue 2 months ago • 1 comments

This PR adds the tag attribute [to_dual_dont_translate] Set, as discussed in https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Order.20dual.20tactic/near/560952736

It is not obvious where this tag should go, since Set and to_dual don't import eachother. A natural place seems to be the place where the sInf/sSup notations are declared for Set, since this is where one could start trying to use to_dual for translating the order on Set.


Open in Gitpod

JovanGerb avatar Dec 14 '25 02:12 JovanGerb

PR summary 1825e179b3

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ sInf_le_sInf + sSup_le_sSup

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

github-actions[bot] avatar Dec 14 '25 02:12 github-actions[bot]

Could you add a comment explaining the attribute (possibly just linking to the Zulip post)?

Thanks! bors d+

bryangingechen avatar Dec 18 '25 16:12 bryangingechen

:v: JovanGerb can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

mathlib-bors[bot] avatar Dec 18 '25 16:12 mathlib-bors[bot]

bors r+

JovanGerb avatar Dec 18 '25 23:12 JovanGerb

Pull request successfully merged into master.

Build succeeded:

mathlib-bors[bot] avatar Dec 19 '25 01:12 mathlib-bors[bot]