mathlib4 icon indicating copy to clipboard operation
mathlib4 copied to clipboard

chore(Order/Iterate): avoid `to_dual existing`

Open JovanGerb opened this issue 2 months ago • 1 comments

This PR adds a few uses of to_dual. Unfortunately many declarations cannot yet really be handled by to_dual because Monotone isn't supported yet.


Open in Gitpod

JovanGerb avatar Dec 14 '25 02:12 JovanGerb

PR summary 1825e179b3

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

- iterate_comp_le_of_le - le_iterate_of_le

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

github-actions[bot] avatar Dec 14 '25 02:12 github-actions[bot]

Thanks! bors r+

bryangingechen avatar Dec 18 '25 16:12 bryangingechen

Build failed:

mathlib-bors[bot] avatar Dec 18 '25 16:12 mathlib-bors[bot]

bors r+

bryangingechen avatar Dec 18 '25 16:12 bryangingechen

Pull request successfully merged into master.

Build succeeded:

mathlib-bors[bot] avatar Dec 18 '25 17:12 mathlib-bors[bot]